[Workflow] Add more tests

lyrixx · lyrixx · commit 3bfb77952eff · 2025-04-11T15:52:48.000+02:00
diff --git a/src/Symfony/Component/Workflow/Tests/Validator/WorkflowValidatorTest.php b/src/Symfony/Component/Workflow/Tests/Validator/WorkflowValidatorTest.php
@@ -12,6 +12,7 @@
 namespace Symfony\Component\Workflow\Tests\Validator;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Workflow\Arc;
 use Symfony\Component\Workflow\Definition;
 use Symfony\Component\Workflow\Exception\InvalidDefinitionException;
 use Symfony\Component\Workflow\Tests\WorkflowBuilderTrait;
@@ -24,8 +25,6 @@ class WorkflowValidatorTest extends TestCase
 
     public function testWorkflowWithInvalidNames()
     {
-        $this->expectException(InvalidDefinitionException::class);
-        $this->expectExceptionMessage('All transitions for a place must have an unique name. Multiple transitions named "t1" where found for place "a" in workflow "foo".');
         $places = range('a', 'c');
 
         $transitions = [];
@@ -35,6 +34,9 @@ public function testWorkflowWithInvalidNames()
 
         $definition = new Definition($places, $transitions);
 
+        $this->expectException(InvalidDefinitionException::class);
+        $this->expectExceptionMessage('All transitions for a place must have an unique name. Multiple transitions named "t1" where found for place "a" in workflow "foo".');
+
         (new WorkflowValidator())->validate($definition, 'foo');
     }
 
@@ -54,4 +56,32 @@ public function testSameTransitionNameButNotSamePlace()
         // the test ensures that the validation does not fail (i.e. it does not throw any exceptions)
         $this->addToAssertionCount(1);
     }
+
+    public function testWithTooManyOutput()
+    {
+        $places = ['a', 'b', 'c'];
+        $transitions = [
+            new Transition('t1', 'a', ['b', 'c']),
+        ];
+        $definition = new Definition($places, $transitions);
+
+        $this->expectException(InvalidDefinitionException::class);
+        $this->expectExceptionMessage('The marking store of workflow "foo" cannot store many places. But the transition "t1" has too many output (2). Only one is accepted.');
+
+        (new WorkflowValidator(true))->validate($definition, 'foo');
+    }
+
+    public function testWithTooManyInitialPlaces()
+    {
+        $places = ['a', 'b', 'c'];
+        $transitions = [
+            new Transition('t1', 'a', 'b'),
+        ];
+        $definition = new Definition($places, $transitions, ['a', 'b']);
+
+        $this->expectException(InvalidDefinitionException::class);
+        $this->expectExceptionMessage('The marking store of workflow "foo" cannot store many places. But the definition has 2 initial places. Only one is supported.');
+
+        (new WorkflowValidator(true))->validate($definition, 'foo');
+    }
 }
