8000 Merge pull request #14537 from webpack/bugfix/future-managed-paths · webpack/webpack@e498f04 · GitHub
[go: up one dir, main page]
Skip to content

Commit e498f04

Browse files
sokrasokra
authored
Merge pull request #14537 from webpack/bugfix/future-managed-paths
fix managed paths regexp handling
2 parents 19ca23f + 217a0be commit e498f04

File tree

5 files changed

+18
-2
lines changed

5 files changed

+18
-2
lines changed

‎lib/FileSystemInfo.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1988,7 +1988,7 @@ class FileSystemInfo {
19881988
for (const managedPath of this.managedPathsRegExps) {
19891989
const match = managedPath.exec(path);
19901990
if (match) {
1991-
const managedItem = getManagedItem(managedPath[1], path);
1991+
const managedItem = getManagedItem(match[1], path);
19921992
if (managedItem) {
19931993
managedItems.add(managedItem);
19941994
managedSet.add(path);
@@ -2962,7 +2962,7 @@ class FileSystemInfo {
29622962
for (const managedPath of this.managedPathsRegExps) {
29632963
const match = managedPath.exec(path);
29642964
if (match) {
2965-
const managedItem = getManagedItem(managedPath[1], path);
2965+
const managedItem = getManagedItem(match[1], path);
29662966
if (managedItem) {
29672967
// construct timestampHash from managed info
29682968
return this.managedItemQueue.add(managedItem, (err, info) => {

‎test/configCases/managedPaths/futureDefaults/index.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import value from "package";
2+
3+
it("should work", () => {
4+
expect(value).toBe(42);
5+
});

‎test/configCases/managedPaths/futureDefaults/node_modules/package/index.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/configCases/managedPaths/futureDefaults/node_modules/package/package.json

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/configCases/managedPaths/futureDefaults/webpack.config.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
/** @type {import("../../../../").Configuration} */
2+
module.exports = {
3+
experiments: {
4+
futureDefaults: true
5+
}
6+
};

0 commit comments

Comments
 (0)
0