fixed protocol-relative URLs

fabpot · fabpot · commit d9cf28d016be · 2014-03-27T10:14:18.000+01:00
diff --git a/src/Symfony/Component/BrowserKit/Client.php b/src/Symfony/Component/BrowserKit/Client.php
@@ -613,7 +613,8 @@ protected function requestFromRequest(Request $request, $changeHistory = true)
     private function updateServerFromUri($server, $uri)
     {
         $server['HTTP_HOST'] = parse_url($uri, PHP_URL_HOST);
-        $server['HTTPS'] = 'https' == parse_url($uri, PHP_URL_SCHEME);
+        $scheme = parse_url($uri, PHP_URL_SCHEME);
+        $server['HTTPS'] = null === $scheme ? $server['HTTPS'] : 'https' == $scheme;
         unset($server['HTTP_IF_NONE_MATCH'], $server['HTTP_IF_MODIFIED_SINCE']);
 
         return $server;
diff --git a/src/Symfony/Component/BrowserKit/Tests/ClientTest.php b/src/Symfony/Component/BrowserKit/Tests/ClientTest.php
@@ -399,7 +399,7 @@ public function testFollowRedirectWithMaxRedirects()
         $this->assertEquals('http://www.example.com/redirected', $client->getRequest()->getUri(), '->followRedirect() follows relative URLs');
 
         $client = new TestClient();
-        $client->setNextResponse(new Response('', 302, array('Location' => 'https://www.example.org/')));
+        $client->setNextResponse(new Response('', 302, array('Location' => '//www.example.org/')));
         $client->request('GET', 'https://www.example.com/');
 
         $this->assertEquals('https://www.example.org/', $client->getRequest()->getUri(), '->followRedirect() follows protocol-relative URLs');

Original file line number	Diff line number	Diff line change
`@@ -613,7 +613,8 @@ protected function requestFromRequest(Request $request, $changeHistory = true)`
`613`	`613`	`private function updateServerFromUri($server, $uri)`
`614`	`614`	`{`
`615`	`615`	`$server['HTTP_HOST'] = parse_url($uri, PHP_URL_HOST);`
`616`		`- $server['HTTPS'] = 'https' == parse_url($uri, PHP_URL_SCHEME);`
	`616`	`+ $scheme = parse_url($uri, PHP_URL_SCHEME);`
	`617`	`+ $server['HTTPS'] = null === $scheme ? $server['HTTPS'] : 'https' == $scheme;`
`617`	`618`	`unset($server['HTTP_IF_NONE_MATCH'], $server['HTTP_IF_MODIFIED_SINCE']);`
`618`	`619`
`619`	`620`	`return $server;`