[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for empty URLs, fragment URLs and url resolution parts of css-values-4 #30552

Merged
merged 1 commit into from
Sep 11, 2021
Merged

Add tests for empty URLs, fragment URLs and url resolution parts of css-values-4 #30552

merged 1 commit into from
Sep 11, 2021

Conversation

smfr
Copy link
Contributor
@smfr smfr commented Sep 10, 2021

Add tests that empty urls serialize to url("") w3c/csswg-drafts#6447, fragment URLs serialize as a fragment, and that urls are resolved relative to the stylesheet and the document base URI as appropriate, including when specified through variables.

@smfr
Copy link
Contributor Author
smfr commented Sep 10, 2021

cc @emilio @gsnedders

@FremyCompany FremyCompany removed their assignment Sep 10, 2021
@FremyCompany FremyCompany requested review from emilio and removed request for FremyCompany September 10, 2021 21:21
Copy link
Contributor
@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Just sanity checking (to know what I need to fix after this lands :)), the tests that Firefox fails after this should just be the serialization of empty urls, to serialize without about:invalid, is that right?

@smfr
Copy link
Contributor Author
smfr commented Sep 11, 2021

css/css-values/urls/fragment-only.html fails in Firefox; url(#foo) should serialize as url("#foo")

@smfr smfr merged commit 107134a into web-platform-tests:master Sep 11, 2021
@smfr smfr deleted the css-values-url-resolution-tests branch September 11, 2021 18:10
@gsnedders
Copy link
Member

c.f. w3c/csswg-drafts#6587 (comment), where the (non-normative) statement from @tabatkins is presumably the justification for this PR changing empty.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants