This repository was archived by the owner on Dec 7, 2023. It is now read-only.
Cleanup error handling for SSH dial #472
Labels
good first issue
Good for newcomers
hacktoberfest
help wanted
Extra attention is needed
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
#469 introduced some quick error handling for the ssh.Dial result.
These conditionals work fine since this should almost always return an expected error, but some of the branches are incorrect.
The final return case is actually a success of the SSH connection. (This is unexpected, and should probably warn the user that an insecure password succeeded)
There may be a better way to auth this connection.
For instance, we could actually use the proper certs since we're going so far as to validate that the server is operating at a protocol level.
The text was updated successfully, but these errors were encountered: