merged branch fabpot/synthetic-service-fix (PR symfony#6827)

fabpot · fabpot · commit 115114b0dc23 · 2013-01-22T08:11:41.000+01:00
This PR was merged into the 2.0 branch. Commits ------- 4119caf [DependencyInjection] fixed the creation of synthetic services in ContainerBuilder Discussion ---------- [DependencyInjection] fixed the creation of synthetic services in ContainerBuilder | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a --------------------------------------------------------------------------- by stof at 2013-01-22T00:14:29Z :+1:
diff --git a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php
@@ -725,6 +725,10 @@ public function findDefinition($id)
      */
     private function createService(Definition $definition, $id)
     {
+        if ($definition->isSynthetic()) {
+            throw new \RuntimeException(sprintf('You have requested a synthetic service ("%s"). The DIC does not know how to construct this service.', $id));
+        }
+
         if (null !== $definition->getFile()) {
             require_once $this->getParameterBag()->resolveValue($definition->getFile());
         }
diff --git a/tests/Symfony/Tests/Component/DependencyInjection/ContainerBuilderTest.php b/tests/Symfony/Tests/Component/DependencyInjection/ContainerBuilderTest.php
@@ -315,6 +315,17 @@ public function testCreateServiceConfigurator()
         }
     }
 
+    /**
+     * @covers Symfony\Component\DependencyInjection\ContainerBuilder::createService
+     * @expectedException \RuntimeException
+     */
+    public function testCreateSyntheticService()
+    {
+        $builder = new ContainerBuilder();
+        $builder->register('foo', 'FooClass')->setSynthetic(true);
+        $builder->get('foo');
+    }
+
     /**
      * @covers Symfony\Component\DependencyInjection\ContainerBuilder::resolveServices
      */

Original file line number	Diff line number	Diff line change
`@@ -725,6 +725,10 @@ public function findDefinition($id)`
`725`	`725`	`*/`
`726`	`726`	`private function createService(Definition $definition, $id)`
`727`	`727`	`{`
	`728`	`+ if ($definition->isSynthetic()) {`
	`729`	`+ throw new \RuntimeException(sprintf('You have requested a synthetic service ("%s"). The DIC does not know how to construct this service.', $id));`
	`730`	`+ }`
	`731`	`+`
`728`	`732`	`if (null !== $definition->getFile()) {`
`729`	`733`	`require_once $this->getParameterBag()->resolveValue($definition->getFile());`
`730`	`734`	`}`