waveray
diff --git a/‎js/server/modules/@arangodb/aql-helper.js
Lines changed: 8 additions & 10 deletions b/‎js/server/modules/@arangodb/aql-helper.js
Lines changed: 8 additions & 10 deletions
diff --git a/‎tests/js/server/aql/aql-graph-traverser.js
Lines changed: 9 additions & 3 deletions b/‎tests/js/server/aql/aql-graph-traverser.js
Lines changed: 9 additions & 3 deletions
@@ -381,20 +381,18 @@ function removeClusterNodesFromPlan (nodes) {
   });
 }
 
-function roundCost (obj) {
+/// @brief recursively removes keys named "estimatedCost" or "selectivityEstimate" of a given object
+/// used in tests where we do not want to test those values because of floating-point values used in "AsserEqual"
+/// This method should only be used where we explicitly don't want to test those values. 
+function removeCost (obj) {
   if (Array.isArray(obj)) {
-    return obj.map(roundCost);
+    return obj.map(removeCost);
   } else if (typeof obj === 'object') {
     var result = {};
     for (var key in obj) {
       if (obj.hasOwnProperty(key)) {
-        if (key === "estimatedCost") {
-          result[key] = Math.round(obj[key]);
-        } else if (key === "selectivityEstimate") {
-          // Round the estimate to 3 digits after ,
-          result[key] = obj[key].toFixed(3);
-        } else {
-          result[key] = roundCost(obj[key]);
+        if (key !== "estimatedCost" || key !== "selectivityEstimate") {
+          result[key] = removeCost(obj[key]);
         }
       }
     }
@@ -422,4 +420,4 @@ exports.getQueryMultiplePlansAndExecutions = getQueryMultiplePlansAndExecutions;
 exports.removeAlwaysOnClusterRules = removeAlwaysOnClusterRules;
 exports.removeClusterNodes = removeClusterNodes;
 exports.removeClusterNodesFromPlan = removeClusterNodesFromPlan;
-exports.roundCost = roundCost;
+exports.removeCost = removeCost;
@@ -40,7 +40,7 @@ const gm = require('@arangodb/general-graph');
 const vn = 'UnitTestVertexCollection';
 const en = 'UnitTestEdgeCollection';
 const isCluster = require('@arangodb/cluster').isCluster();
-const roundCost = require('@arangodb/aql-helper').roundCost;
+const removeCost = require('@arangodb/aql-helper').removeCost;
 
 var _ = require('lodash');
 var vertex = {};
@@ -2218,13 +2218,19 @@ function optimizeInSuite() {
       var noOptPlans = AQL_EXPLAIN(vertexQuery, bindVars, noOpt).plan;
       assertEqual(optPlans.rules, []);
       // This query cannot be optimized by traversal rule
-      assertEqual(roundCost(optPlans), roundCost(noOptPlans));
+      // we do not want to test estimatedCost or selectivityEstimate here
+      // 1.) subject to rounding errors and other fluctuations
+      // 2.) absolute numbers for estimatedCost and selectivityEstimate are an implementation detail and meaningless for this test.
+      assertEqual(removeCost(optPlans), removeCost(noOptPlans));
 
       optPlans = AQL_EXPLAIN(edgeQuery, bindVars, opt).plan;
       noOptPlans = AQL_EXPLAIN(edgeQuery, bindVars, noOpt).plan;
       assertEqual(optPlans.rules, []);
       // This query cannot be optimized by traversal rule
-      assertEqual(roundCost(optPlans), roundCost(noOptPlans));
+      // we do not want to test estimatedCost or selectivityEstimate here
+      // 1.) subject to rounding errors and other fluctuations
+      // 2.) absolute numbers for estimatedCost and selectivityEstimate are an implementation detail and meaningless for this test.
+      assertEqual(removeCost(optPlans), removeCost(noOptPlans));
     }
   };
 }