8000 Deprecate Display's constructor arg set_vertical_scroll · warmbit/circuitpython@379461d · GitHub
[go: up one dir, main page]
Skip to content

Commit 379461d

Browse files
jeplerjepler
committed
Deprecate Display's constructor arg set_vertical_scroll
1 parent 283b7e3 commit 379461d

File tree

23 files changed

+4
-25
lines changed

23 files changed

+4
-25
lines changed

‎ports/atmel-samd/boards/hallowing_m0_express/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ void board_init(void) {
100100
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
101101
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
102102
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
103-
0x37, // set vertical scroll command
104103
display_init_sequence,
105104
sizeof(display_init_sequence),
106105
&pin_PA00,

‎ports/atmel-samd/boards/hallowing_m4_express/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ void board_init(void) {
8080
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
8181
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
8282
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
83-
0x37, // set vertical scroll command
8483
display_init_sequence,
8584
sizeof(display_init_sequence),
8685
&pin_PB14, // backlight pin

‎ports/atmel-samd/boards/monster_m4sk/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ void board_init(void) {
8181
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
8282
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
8383
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
84-
0x37, // set vertical scroll command
8584
display_init_sequence,
8685
sizeof(display_init_sequence),
8786
&pin_PA23, // backlight pin

‎ports/atmel-samd/boards/pewpew_m4/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ void board_init(void) {
133133
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
134134
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
135135
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
136-
0x37, // set vertical scroll command
137136
display_init_sequence,
138137
sizeof(display_init_sequence),
139138
NULL, // backlight pin

‎ports/atmel-samd/boards/pybadge/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ void board_init(void) {
103103
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
104104
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
105105
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
106-
0x37, // set vertical scroll command
107106
display_init_sequence,
108107
sizeof(display_init_sequence),
109108
&pin_PA01, // backlight pin

‎ports/atmel-samd/boards/pygamer/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ void board_init(void) {
103103
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
104104
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
105105
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
106-
0x37, // set vertical scroll command
107106
display_init_sequence,
108107
sizeof(display_init_sequence),
109108
&pin_PA01, // backlight pin

‎ports/atmel-samd/boards/pyportal/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ void board_init(void) {
9090
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
9191
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
9292
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
93-
0x37, // Set vertical scroll command
9493
display_init_sequence,
9594
sizeof(display_init_sequence),
9695
&pin_PB31, // Backlight pin

‎ports/atmel-samd/boards/pyportal_titano/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ void board_init(void) {
107107
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
108108
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
109109
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
110-
0x37, // Set vertical scroll command
111110
display_init_sequence,
112111
sizeof(display_init_sequence),
113112
&pin_PB31, // Backlight pin

‎ports/atmel-samd/boards/seeeduino_wio_terminal/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ void board_init(void) {
9898
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
9999
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
100100
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
101-
0x37, // set vertical scroll command
102101
display_init_sequence,
103102
sizeof(display_init_sequence),
104103
&pin_PC05, // backlight pin

‎ports/atmel-samd/boards/ugame10/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ void board_init(void) {
100100
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
101101
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
102102
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
103-
0x37, // set vertical scroll command
104103
display_init_sequence,
105104
sizeof(display_init_sequence),
106105
NULL,

‎ports/esp32s2/boards/adafruit_feather_esp32s2_tftback_nopsram/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ void board_init(void) {
9494
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
9595
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
9696
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
97-
0x37, // set vertical scroll command
9897
display_init_sequence,
9998
sizeof(display_init_sequence),
10099
&pin_GPIO7, // backlight pin

‎ports/esp32s2/boards/adafruit_funhouse/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ void board_init(void) {
9797
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
9898
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
9999
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
100-
0x37, // set vertical scroll command
101100
display_init_sequence,
102101
sizeof(display_init_sequence),
103102
&pin_GPIO21, // backlight pin

‎ports/esp32s2/boards/lilygo_ttgo_t8_s2_st7789/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ static void display_init(void) {
113113
MIPI_COMMAND_SET_COLUMN_ADDRESS, // set column command
114114
MIPI_COMMAND_SET_PAGE_ADDRESS, // set row command
115115
MIPI_COMMAND_WRITE_MEMORY_START, // write memory command
116-
0x37, // set vertical scroll command
117116
display_init_sequence,
118117
sizeof(display_init_sequence),
119118
&pin_GPIO33, // backlight pin

‎ports/esp32s2/boards/morpheans_morphesp-240/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,6 @@ void board_init(void) {
198198
MIPI_COMMAND_SET_COLUMN_ADDRESS, // set column command
199199
MIPI_COMMAND_SET_PAGE_ADDRESS, // set row command
200200
MIPI_COMMAND_WRITE_MEMORY_START, // write memory command
201-
0x37, // set vertical scroll command
202201
display_init_sequence,
203202
sizeof(display_init_sequence),
204203
NULL, // There is no backlight pin, defined for now.

‎ports/nrf/boards/clue_nrf52840_express/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ void board_init(void) {
8080
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
8181
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
8282
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
83-
0x37, // set vertical scroll command
8483
display_init_sequence,
8584
sizeof(display_init_sequence),
8685
&pin_P1_05, // backlight pin

‎ports/nrf/boards/hiibot_bluefi/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ void board_init(void) {
8181
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
8282
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
8383
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
84-
0x37, // set vertical scroll command
8584
display_init_sequence,
8685
sizeof(display_init_sequence),
8786
&pin_P1_13, // backlight pin

‎ports/nrf/boards/makerdiary_nrf52840_m2_devkit/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ void board_init(void) {
8181
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
8282
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
8383
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
84-
37, // set vertical scroll command
8584
display_init_sequence,
8685
sizeof(display_init_sequence),
8786
&pin_P0_20, // backlight pin

‎ports/nrf/boards/ohs2020_badge/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ void board_init(void) {
8080
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
8181
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
8282
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
83-
0x37, // set vertical scroll command
8483
display_init_sequence,
8584
sizeof(display_init_sequence),
8685
&pin_P0_02, // backlight pin

‎ports/raspberrypi/boards/adafruit_macropad_rp2040/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ void board_init(void) {
9191
0, // Set column command
9292
0, // Set row command
9393
0, // Write memory command
94-
0xd3, // set vertical scroll command
9594
display_init_sequence,
9695
sizeof(display_init_sequence),
9796
NULL,

‎ports/stm/boards/meowbit_v121/board.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ void board_init(void) {
100100
MIPI_COMMAND_SET_COLUMN_ADDRESS, // Set column command
101101
MIPI_COMMAND_SET_PAGE_ADDRESS, // Set row command
102102
MIPI_COMMAND_WRITE_MEMORY_START, // Write memory command
103-
0x37, // set vertical scroll command
104103
display_init_sequence,
105104
sizeof(display_init_sequence),
106105
&pin_PB03,

‎shared-bindings/displayio/Display.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
//| Most people should not use this class directly. Use a specific display driver instead that will
5555
//| contain the initialization sequence at minimum."""
5656
//|
57-
//| def __init__(self, display_bus: _DisplayBus, init_sequence: ReadableBuffer, *, width: int, height: int, colstart: int = 0, rowstart: int = 0, rotation: int = 0, color_depth: int = 16, grayscale: bool = False, pixels_in_byte_share_row: bool = True, bytes_per_cell: int = 1, reverse_pixels_in_byte: bool = False, set_column_command: int = 0x2a, set_row_command: int = 0x2b, write_ram_command: int = 0x2c, set_vertical_scroll: int = 0, backlight_pin: Optional[microcontroller.Pin] = None, brightness_command: Optional[int] = None, brightness: float = 1.0, auto_brightness: bool = False, single_byte_bounds: bool = False, data_as_commands: bool = False, auto_refresh: bool = True, native_frames_per_second: int = 60, backlight_on_high: bool = True, SH1107_addressing: bool = False) -> None:
57+
//| def __init__(self, display_bus: _DisplayBus, init_sequence: ReadableBuffer, *, width: int, height: int, colstart: int = 0, rowstart: int = 0, rotation: int = 0, color_depth: int = 16, grayscale: bool = False, pixels_in_byte_share_row: bool = True, bytes_per_cell: int = 1, reverse_pixels_in_byte: bool = False, set_column_command: int = 0x2a, set_row_command: int = 0x2b, write_ram_command: int = 0x2c, backlight_pin: Optional[microcontroller.Pin] = None, brightness_command: Optional[int] = None, brightness: float = 1.0, auto_brightness: bool = False, single_byte_bounds: bool = False, data_as_commands: bool = False, auto_refresh: bool = True, native_frames_per_second: int = 60, backlight_on_high: bool = True, SH1107_addressing: bool = False) -> None:
5858
//| r"""Create a Display object on the given display bus (`FourWire`, `ParallelBus` or `I2CDisplay`).
5959
//|
6060
//| The ``init_sequence`` is bitpacked to minimize the ram impact. Every command begins with a
@@ -100,7 +100,6 @@
100100
//| :param int set_column_command: Command used to set the start and end columns to update
101101
//| :param int set_row_command: Command used so set the start and end rows to update
102102
//| :param int write_ram_command: Command used to write pixels values into the update region. Ignored if data_as_commands is set.
103-
//| :param int set_vertical_scroll: Command used to set the first row to show
104103
//| :param microcontroller.Pin backlight_pin: Pin connected to the display's backlight
105104
//| :param int brightness_command: Command to set display brightness. Usually available in OLED controllers.
106105
//| :param float brightness: Initial display brightness. This value is ignored if auto_brightness is True.
@@ -111,6 +110,7 @@
111110
//| :param int native_frames_per_second: Number of display refreshes per second that occur with the given init_sequence.
112111
//| :param bool backlight_on_high: If True, pulling the backlight pin high turns the backlight on.
113112
//| :param bool SH1107_addressing: Special quirk for SH1107, use upper/lower column set and page set
113+
//| :param int set_vertical_scroll: This parameter is accepted but ignored for backwards compatibility. It will be removed in a future release.
114114
//| """
115115
//| ...
116116
//|
@@ -184,7 +184,6 @@ STATIC mp_obj_t displayio_display_make_new(const mp_obj_type_t *type, size_t n_a
184184
args[ARG_reverse_bytes_in_word].u_bool,
185185
args[ARG_set_column_command].u_int, args[ARG_set_row_command].u_int,
186186
args[ARG_write_ram_command].u_int,
187-
args[ARG_set_vertical_scroll].u_int,
188187
bufinfo.buf, bufinfo.len,
189188
MP_OBJ_TO_PTR(backlight_pin),
190189
args[ARG_brightness_command].u_int,

‎shared-bindings/displayio/Display.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ void common_hal_displayio_display_construct(displayio_display_obj_t *self,
4242
mp_obj_t bus, uint16_t width, uint16_t height,
4343
int16_t colstart, int16_t rowstart, uint16_t rotation, uint16_t color_depth, bool grayscale,
4444
bool pixels_in_byte_share_row, uint8_t bytes_per_cell, bool reverse_pixels_in_byte, bool reverse_bytes_in_word,
45-
uint8_t set_column_command, uint8_t set_row_command, uint8_t write_ram_command, uint8_t set_vertical_scroll,
45+
uint8_t set_column_command, uint8_t set_row_command, uint8_t write_ram_command,
4646
uint8_t *init_sequence, uint16_t init_sequence_len, const mcu_pin_obj_t *backlight_pin, uint16_t brightness_command,
4747
mp_float_t brightness, bool auto_brightness,
4848
bool single_byte_bounds, bool data_as_commands, bool auto_refresh, uint16_t native_frames_per_second,

‎shared-module/displayio/Display.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ void common_hal_displayio_display_construct(displayio_display_obj_t *self,
4545
mp_obj_t bus, uint16_t width, uint16_t height, int16_t colstart, int16_t rowstart,
4646
uint16_t rotation, uint16_t color_depth, bool grayscale, bool pixels_in_byte_share_row,
4747
uint8_t bytes_per_cell, bool reverse_pixels_in_byte, bool reverse_bytes_in_word, uint8_t set_column_command,
48-
uint8_t set_row_command, uint8_t write_ram_command, uint8_t set_vertical_scroll,
48+
uint8_t set_row_command, uint8_t write_ram_command,
4949
uint8_t *init_sequence, uint16_t init_sequence_len, const mcu_pin_obj_t *backlight_pin,
5050
uint16_t brightness_command, mp_float_t brightness, bool auto_brightness,
5151
bool single_byte_bounds, bool data_as_commands, bool auto_refresh, uint16_t native_frames_per_second,

0 commit comments

Comments
 (0)
0