[css-ui-4] Add 'field-sizing' property #9251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My plan is that more detailed behavior is described in the HTML standard. |
|
Per #7542 (comment), the names "normal" and "auto" aren't very illuminating here. (And, notably, as defined here they appear to be the exact opposite of what I expected them to be - I expected "normal" to be the legacy half-replaced behavior, while "auto" was the new 'act like other elements' behavior. That's a good argument for the names being bad!) Maybe we should go with |
|
@tabatkins Let's discuss keywords in #7542 |
1 task
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 4, 2023
w3c/csswg-drafts#9251 This CL adds form-sizing property, based on the syntax `form-sizing: auto | normal`. The property doesn't have any effect yet. A property value is mapped to a boolean field of ComputedStyle. This CL has no user-visible behavior changes. The property is behind a runtime flag. Bug: 1447058 Change-Id: I5f8f6bab703b9bef761f8886967b86d43a2500ee
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 4, 2023
w3c/csswg-drafts#9251 This CL adds form-sizing property, based on the syntax `form-sizing: auto | normal`. The property doesn't have any effect yet. A property value is mapped to a boolean field of ComputedStyle. This CL has no user-visible behavior changes. The property is behind a runtime flag. Bug: 1447058 Change-Id: I5f8f6bab703b9bef761f8886967b86d43a2500ee
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 4, 2023
w3c/csswg-drafts#9251 This CL adds form-sizing property, based on the syntax `form-sizing: auto | normal`. The property doesn't have any effect yet. This CL has no user-visible behavior changes. The property is behind a runtime flag. Bug: 1447058 Change-Id: I5f8f6bab703b9bef761f8886967b86d43a2500ee
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 4, 2023
w3c/csswg-drafts#9251 This CL adds form-sizing property, based on the syntax `form-sizing: auto | normal`. The property doesn't have any effect yet. This CL has no user-visible behavior changes. The property is behind a runtime flag. Bug: 1447058 Change-Id: I5f8f6bab703b9bef761f8886967b86d43a2500ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4835497 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1192006}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 4, 2023
w3c/csswg-drafts#9251 This CL adds form-sizing property, based on the syntax `form-sizing: auto | normal`. The property doesn't have any effect yet. This CL has no user-visible behavior changes. The property is behind a runtime flag. Bug: 1447058 Change-Id: I5f8f6bab703b9bef761f8886967b86d43a2500ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4835497 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1192006}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 4, 2023
w3c/csswg-drafts#9251 This CL adds form-sizing property, based on the syntax `form-sizing: auto | normal`. The property doesn't have any effect yet. This CL has no user-visible behavior changes. The property is behind a runtime flag. Bug: 1447058 Change-Id: I5f8f6bab703b9bef761f8886967b86d43a2500ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4835497 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1192006}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 13, 2023
…only Automatic update from web-platform-tests css-ui: Add form-sizing property w3c/csswg-drafts#9251 This CL adds form-sizing property, based on the syntax `form-sizing: auto | normal`. The property doesn't have any effect yet. This CL has no user-visible behavior changes. The property is behind a runtime flag. Bug: 1447058 Change-Id: I5f8f6bab703b9bef761f8886967b86d43a2500ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4835497 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1192006} -- wpt-commits: 1b77380f2016401b75bd009d78b9d350010191d3 wpt-pr: 41789
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Sep 14, 2023
…only Automatic update from web-platform-tests css-ui: Add form-sizing property w3c/csswg-drafts#9251 This CL adds form-sizing property, based on the syntax `form-sizing: auto | normal`. The property doesn't have any effect yet. This CL has no user-visible behavior changes. The property is behind a runtime flag. Bug: 1447058 Change-Id: I5f8f6bab703b9bef761f8886967b86d43a2500ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4835497 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1192006} -- wpt-commits: 1b77380f2016401b75bd009d78b9d350010191d3 wpt-pr: 41789
|
Updated this PR for @frivoal would you take a loot at this please? |
frivoal
approved these changes
Oct 12, 2023
frivoal
requested changes
Oct 12, 2023
There was a problem hiding this comment.
Unless I am missing something, it seems to me that we'd be better off expressing the difference between the two modes in terms of intrinsic size rather than talking directly about the preferred size properties. That gets the desired effect into all aspects of sizing, which is my understanding of the groups resolution.
I've made suggested edits implementing that change. Let me know if you think these work, or if I missed subtlety you were deliberately introducing by using the proposed wording.
Thanks! I accepted all your suggestions. |
|
@frivoal would you take a loot at this again please? |
frivoal
approved these changes
Oct 27, 2023
Co-authored-by: Florian Rivoal <git@florian.rivoal.net>
Co-authored-by: Florian Rivoal <git@florian.rivoal.net>
Co-authored-by: Florian Rivoal <git@florian.rivoal.net>
63a58c8 to
0bd211e
Compare
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
w3c/csswg-drafts#9251 This CL adds form-sizing property, based on the syntax `form-sizing: auto | normal`. The property doesn't have any effect yet. This CL has no user-visible behavior changes. The property is behind a runtime flag. Bug: 1447058 Change-Id: I5f8f6bab703b9bef761f8886967b86d43a2500ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4835497 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1192006}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7542