8000 [css-values-4] Section 6.1: Removed the word "unit" to avoid confusion by facorread · Pull Request #8489 · w3c/csswg-drafts · GitHub
[go: up one dir, main page]

Skip to content

Conversation

facorread
Copy link
Contributor

Non-substantive contribution for grammar

@tabatkins
Copy link
Member

I'm not sure what the motivation behind this change is. The spec reads fine as-is.

(You've also made several additional changes - the very first edit deletes part of the end tag, you've removed some caniuse attributes, etc.)

@facorread
Copy link
Contributor Author

Honestly I am an outsider to all of this. Here is a screenshot of the standard today:

image

The screenshot shows that the definitions do not have the word ' unit' inside the single quotes before section 6.1.1; the confusion I was alluding to is that it makes it seem viable to write

h1 {
    font-size: 1.2em unit
}

Similarly, I inferred that the caniuse values in the diff were derived from those typos.

Please let me know if these changes are introducing more problems than they fix.

@tabatkins
Copy link
Member

If you want to move the word "unit" out of the dfn element, so it won't be inside the generated quotes, that would be fine with me.

@facorread
Copy link
Contributor Author

I am happy to move the word "unit" out of dfn 8000 ; I am not sure if there is some sort of standard way of building these titles. In another screenshot, the definitions at Section 7 come without "units" or any other word accompanying them whatsoever:

image

@tabatkins
Copy link
Member

Ah, fair. Might as well be consistent. Okay, well fix the markup error your very first edit introduces, and put the caniuse attribute back, and I can accept this. You can go ahead and remove the lt attributes as well, since they'll be matching the text content and thus are unnecessary.

Thanks for the comments and reviews.
@tabatkins tabatkins merged commit e7c1c82 into w3c:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0