[cssom] Define legacy CSSStyleSheet methods as implemented in Blink. #3900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
307cccc to
ffe6f2b
Compare
|
WPT tests in https://bugzilla.mozilla.org/show_bug.cgi?id=1545823 |
bzbarsky
reviewed
May 8, 2019
bzbarsky
reviewed
May 8, 2019
4128217 to
5bdfa67
Compare
domenic
reviewed
May 9, 2019
cssom-1/Overview.bs
Outdated
| void deleteRule(unsigned long index); | ||
|
|
||
| [SameObject] readonly attribute CSSRuleList rules; | ||
| long addRule(optional DOMString selector = "undefined", optional DOMString style = "undefined", optional unsigned long index); |
There was a problem hiding this comment.
Wow. I guess in Blink this is done via https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/css/css_style_sheet.idl?q=css_style_sheet.idl&sq=package:chromium&g=0&l=1 which bottoms out at https://chromium.googlesource.com/chromium/src/+/master/third_party/blink/renderer/bindings/IDLExtendedAttributes.md#DefaultValue_p
/cc @yuki3 as Blink bindings team member. I hope we can get rid of [DefaultValue] and prevent any future APIs from ending up this weird.
tabatkins
approved these changes
May 9, 2019
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 9, 2019
…et.addRule and CSSStyleSheet.removeRule. r=bzbarsky It's not worth dying on this hill. Both Blink and WebKit pass the tests. (Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules are not the same JS object, WebKit returns a new rule list. I'll file) Spec PR in w3c/csswg-drafts#3900. Differential Revision: https://phabricator.services.mozilla.com/D30348 --HG-- extra : moz-landing-system : lando
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
May 9, 2019
…et.addRule and CSSStyleSheet.removeRule. r=bzbarsky It's not worth dying on this hill. Both Blink and WebKit pass the tests. (Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules are not the same JS object, WebKit returns a new rule list. I'll file) Spec PR in w3c/csswg-drafts#3900. Differential Revision: https://phabricator.services.mozilla.com/D30348
5bdfa67 to
ed0ac45
Compare
|
Tweaked the text so that the header is properly nested under the previous section, and add some advisement text to discourage usage. Normative text is the same. |
ed0ac45 to
0f10d5e
Compare
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 16, 2019
… CSSStyleSheet.removeRule. It's not worth dying on this hill. Both Blink and WebKit pass the tests. (Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules are not the same JS object, WebKit returns a new rule list. I'll file) Spec PR in w3c/csswg-drafts#3900. Differential Revision: https://phabricator.services.mozilla.com/D30348 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1545823 gecko-commit: a93ed2a80220b9ba15fb9b59ea79b5f1ee8f7693 gecko-integration-branch: central gecko-reviewers: bzbarsky
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 16, 2019
… CSSStyleSheet.removeRule. It's not worth dying on this hill. Both Blink and WebKit pass the tests. (Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules are not the same JS object, WebKit returns a new rule list. I'll file) Spec PR in w3c/csswg-drafts#3900. Differential Revision: https://phabricator.services.mozilla.com/D30348 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1545823 gecko-commit: a93ed2a80220b9ba15fb9b59ea79b5f1ee8f7693 gecko-integration-branch: central gecko-reviewers: bzbarsky
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
… CSSStyleSheet.removeRule. It's not worth dying on this hill. Both Blink and WebKit pass the tests. (Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules are not the same JS object, WebKit returns a new rule list. I'll file) Spec PR in w3c/csswg-drafts#3900. Differential Revision: https://phabricator.services.mozilla.com/D30348 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1545823 gecko-commit: a93ed2a80220b9ba15fb9b59ea79b5f1ee8f7693 gecko-integration-branch: central gecko-reviewers: bzbarsky
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…et.addRule and CSSStyleSheet.removeRule. r=bzbarsky It's not worth dying on this hill. Both Blink and WebKit pass the tests. (Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules are not the same JS object, WebKit returns a new rule list. I'll file) Spec PR in w3c/csswg-drafts#3900. Differential Revision: https://phabricator.services.mozilla.com/D30348 UltraBlame original commit: a93ed2a80220b9ba15fb9b59ea79b5f1ee8f7693
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…et.addRule and CSSStyleSheet.removeRule. r=bzbarsky It's not worth dying on this hill. Both Blink and WebKit pass the tests. (Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules are not the same JS object, WebKit returns a new rule list. I'll file) Spec PR in w3c/csswg-drafts#3900. Differential Revision: https://phabricator.services.mozilla.com/D30348 UltraBlame original commit: a93ed2a80220b9ba15fb9b59ea79b5f1ee8f7693
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…et.addRule and CSSStyleSheet.removeRule. r=bzbarsky It's not worth dying on this hill. Both Blink and WebKit pass the tests. (Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules are not the same JS object, WebKit returns a new rule list. I'll file) Spec PR in w3c/csswg-drafts#3900. Differential Revision: https://phabricator.services.mozilla.com/D30348 UltraBlame original commit: a93ed2a80220b9ba15fb9b59ea79b5f1ee8f7693
hawkeye116477
added a commit
to hawkeye116477/Waterfox
that referenced
this pull request
Dec 28, 2019
…et.addRule and CSSStyleSheet.removeRule. r=bzbarsky Spec PR in w3c/csswg-drafts#3900.
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…et.addRule and CSSStyleSheet.removeRule. r=bzbarsky It's not worth dying on this hill. Both Blink and WebKit pass the tests. (Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules are not the same JS object, WebKit returns a new rule list. I'll file) Spec PR in w3c/csswg-drafts#3900. Differential Revision: https://phabricator.services.mozilla.com/D30348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3814.