10BC0 [selectors-4] Rename :focus-ring to :focus-visible by alice · Pull Request #2104 · w3c/csswg-drafts · GitHub
[go: up one dir, main page]
Skip to content

[selectors-4] Rename :focus-ring to :focus-visible #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2017
Merged

[selectors-4] Rename :focus-ring to :focus-visible #2104

merged 2 commits into from
Dec 18, 2017

Conversation

alice
Copy link
@alice alice commented Dec 12, 2017 •
edited
Loading

Per discussion in #2036

@alice alice mentioned this pull request Dec 12, 2017
Merged
@alice alice changed the title [selectors4] Rename :focus-ring to :focus-visible [selectors-4] Rename :focus-ring to :focus-visible Dec 12, 2017
@frivoal
Copy link
Collaborator
frivoal commented Dec 12, 2017

Looks good to me.

Just one little non essential comment:
This has been up under the focus-ring name for a while, so there could be quite a few inbound links. Just in case, it could be nice to keep a (hidden) element with the old ids (the-focusring-pseudo, focus-ring-pseudo) near the new ones, to keep the links working.

@alice
Copy link
Author
alice commented Dec 12, 2017

Good idea, will fix.

@tabatkins
Copy link
Member

This is done by adding oldids="whatever" to the heading element, btw. No need to manually add an element.

@alice
Copy link
Author
alice commented Dec 12, 2017

Done.

@alice
Copy link
Author
alice commented Dec 14, 2017

I can't pull this but seems like it's ready to go?

@ewilligers ewilligers merged commit bdf1ca9 into w3c:master Dec 18, 2017
This was referenced Dec 28, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alice @frivoal @tabatkins @ewilligers
0