[mediaqueries-5] Add viewport segment media features #6234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tabatkins - mind taking a look? Thanks! |
|
Friendly ping @frivoal @tabatkins |
|
I'm hoping to make progress on these features over this quarter, so will probably merge this shortly unless there are any objections. The additions are relatively small, so I'm comfortable hashing out feedback via follow up issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new media feature that allow for authors to detect situations where the viewport is logically separated based on the window's configuration with respect to display features. This is designed to allow authors to target foldable devices where the viewport spans multiple displays (logical or physical).
There are features for both the horizontal and vertical directions and are integers so that future form factors (think a tri-fold device) that do not yet exist can be explicitly detected and supported by authors.
Fixes #5621