-
Notifications
You must be signed in to change notification settings - Fork 747
Closed
Labels
Description
I was a few seconds late providing review feedback on #5711 . It's probably easier to read my comments inline there, but I'll repeat them here.
- Minor typo: corresponds
- The spec needs to describe animation, specifically that it works the same as SVG paths since the
shape
syntax is a mapping to SVG path primitives. It should probably call out the fact that thecurve
operator actually produces two segment types, so it may not be possible to smoothly animate between twocurve
s. - For that reason, I'd consider splitting cubic and quadratic into different operations rather than rely on the number of parameters
- Similarly, a
curve
andsmooth
might actually be the same segment type as far as animation is concerned! Confusing! - I don't think
via
is a good term for bezier control points. The curve does not (typically) go through those points, which is what the definition of via would suggest. Maybeusing
is a better term? - In SVG syntax you specify the control points before the end point. Is there a reason this was not followed here? The rationale behind that in SVG is that the point specified last in commands is where the pen ends up (where the next segment starts).
ByteEater-pl and SebastianSimon