shold emit webpack Error rather than throwing (#256)

Eden-Sun · yyx990803 · commit 322cf4df3035 · 2016-06-15T23:42:34.000-04:00
* shold emit webpack Error rather than throwing

* just callback can emit the error

* should return
diff --git a/lib/template-loader.js b/lib/template-loader.js
@@ -27,19 +27,20 @@ module.exports = function (content) {
   }
 
   if (!cons[opt.engine]) {
-    throw new Error(
+    return callback(new Error(
       'Template engine \'' + opt.engine + '\' ' +
       'isn\'t available in Consolidate.js'
-    )
+    ))
   }
 
   // for relative includes
   opt.filename = this.resourcePath
 
   cons[opt.engine].render(content, opt, function (err, html) {
     if (err) {
-      throw err
+      callback(err)
+    } else {
+      exportContent(html)
     }
-    exportContent(html)
   })
 }

Original file line number	Diff line number	Diff line change
`@@ -27,19 +27,20 @@ module.exports = function (content) {`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`if (!cons[opt.engine]) {`
`30`		`- throw new Error(`
	`30`	`+ return callback(new Error(`
`31`	`31`	`'Template engine \'' + opt.engine + '\' ' +`
`32`	`32`	`'isn\'t available in Consolidate.js'`
`33`		`- )`
	`33`	`+ ))`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`// for relative includes`
`37`	`37`	`opt.filename = this.resourcePath`
`38`	`38`
`39`	`39`	`cons[opt.engine].render(content, opt, function (err, html) {`
`40`	`40`	`if (err) {`
`41`		`- throw err`
	`41`	`+ callback(err)`
	`42`	`+ } else {`
	`43`	`+ exportContent(html)`
`42`	`44`	`}`
`43`		`- exportContent(html)`
`44`	`45`	`})`
`45`	`46`	`}`