8000 chore: move yorkie from cli-service to plugin-eslint & plugin-typescr… · vuejs/vue-cli@271bf39 · GitHub
[go: up one dir, main page]
Skip to content

Commit 271bf39

Browse files
haoqunjianghaoqunjiang
authored
chore: move yorkie from cli-service to plugin-eslint & plugin-typescript (#4153)
It is because yorkie is not used anywhere in @vue/cli-service, but only included for the `lintOn: 'commit'` feature of eslint & typescript plugin. Also, a lot of global installation issues are caused by the yorkie postinstall script. Moving it out of the dependency chain of `@vue/cli` mitigates such issues.
1 parent 070b2e4 commit 271bf39

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

‎packages/@vue/cli-plugin-eslint/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@
2626
"@vue/cli-shared-utils": "^4.0.0-alpha.1",
2727
"eslint-loader": "^2.1.2",
2828
"globby": "^9.2.0",
29-
"webpack": ">=4 < 4.29"
29+
"webpack": ">=4 < 4.29",
30+
"yorkie": "^2.0.0"
3031
},
3132
"peerDependencies": {
3233
"eslint": ">= 1.6.0"

‎packages/@vue/cli-plugin-typescript/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929
"globby": "^9.2.0",
3030
"ts-loader": "^6.0.1",
3131
"tslint": "^5.16.0",
32-
"webpack": ">=4 < 4.29"
32+
"webpack": ">=4 < 4.29",
33+
"yorkie": "^2.0.0"
3334
},
3435
"peerDependencies": {
3536
"typescript": ">=2"

‎packages/@vue/cli-service/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,7 @@
7777
"webpack-bundle-analyzer": "^3.3.2",
7878
"webpack-chain": "^6.0.0",
7979
"webpack-dev-server": "^3.4.1",
80-
"webpack-merge": "^4.2.1",
81-
"yorkie": "^2.0.0"
80+
"webpack-merge": "^4.2.1"
8281
},
8382
"peerDependencies": {
8483
"vue-template-compiler": "^2.0.0"

0 commit comments

Comments
 (0)
0