fix: prefer devServer.public as the custom url for browser to open (#4169)

Devil-Cong · haoqunjiang · commit 082440752dc1 · 2019-06-24T16:51:26.000+08:00
fixes #3747 (cherry picked from commit 76e7c38)
diff --git a/packages/@vue/cli-service/lib/commands/serve.js b/packages/@vue/cli-service/lib/commands/serve.js
@@ -92,6 +92,7 @@ module.exports = (api, options) => {
       port,
       isAbsoluteUrl(options.publicPath) ? '/' : options.publicPath
     )
+    const localUrlForBrowser = publicUrl || urls.localUrlForBrowser
 
     const proxySettings = prepareProxy(
       projectDevServerOptions.proxy,
@@ -201,7 +202,7 @@ module.exports = (api, options) => {
         let copied = ''
         if (isFirstCompile && args.copy) {
           try {
-            require('clipboardy').writeSync(urls.localUrlForBrowser)
+            require('clipboardy').writeSync(localUrlForBrowser)
             copied = chalk.dim('(copied to clipboard)')
           } catch (_) {
             /* catch exception if copy to clipboard isn't supported (e.g. WSL), see issue #3476 */
@@ -250,15 +251,15 @@ module.exports = (api, options) => {
             const pageUri = (projectDevServerOptions.openPage && typeof projectDevServerOptions.openPage === 'string')
               ? projectDevServerOptions.openPage
               : ''
-            openBrowser(urls.localUrlForBrowser + pageUri)
+            openBrowser(localUrlForBrowser + pageUri)
           }
 
           // Send final app URL
           if (args.dashboard) {
             const ipc = new IpcMessenger()
             ipc.send({
               vueServe: {
-                url: urls.localUrlForBrowser
+                url: localUrlForBrowser
               }
             })
           }
@@ -267,7 +268,7 @@ module.exports = (api, options) => {
           // so other commands can do api.service.run('serve').then(...)
           resolve({
             server,
-            url: urls.localUrlForBrowser
+            url: localUrlForBrowser
           })
         } else if (process.env.VUE_CLI_TEST) {
           // signal for test to check HMR
