fix(types): relax the return type of props default option #8537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b35b1db to
8f2b516
Compare
|
Maybe |
HerringtonDarkholme
approved these changes
Jul 21, 2018
|
thx! let zIndex = 5000
export default Vue.extend({
name: 'Popup',
props: {
zIndex: {
type: Number,
default: (): number => zIndex++
}
}
}) |
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
aJean
pushed a commit
to aJean/vue
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchOther information:
Currently, the return type of
defaultoption is annotated withobjectsince it is used for generating fresh object for each component instance. But there is another use case fordefaultoption of function in portal-vue which is for dynamically generating unique value as default.https://github.com/LinusBorg/portal-vue/blob/develop/src/components/portal.js#L16
The current typing breaks
thistype inference when thedefaultfunction returns non-object type. I just relaxed the return type toanyto avoid breaking the inference.