fix(runtime-core): fix child node unloading in v-for

Alfred-Skyblue · Alfred-Skyblue · commit 80a2c6b7869f · 2023-09-18T11:39:26.000+08:00
diff --git a/packages/runtime-core/src/renderer.ts b/packages/runtime-core/src/renderer.ts
@@ -35,7 +35,8 @@ import {
   NOOP,
   invokeArrayFns,
   isArray,
-  getGlobalThis
+  getGlobalThis,
+  isString
 } from '@vue/shared'
 import {
   queueJob,
@@ -2117,19 +2118,31 @@ function baseCreateRenderer(
           doRemove
         )
       } else if (
-        dynamicChildren &&
+        (dynamicChildren || children) &&
         // #1153: fast path should not be taken for non-stable (v-for) fragments
         (type !== Fragment ||
           (patchFlag > 0 && patchFlag & PatchFlags.STABLE_FRAGMENT))
       ) {
-        // fast path for block nodes: only need to unmount dynamic children.
-        unmountChildren(
-          dynamicChildren,
-          parentComponent,
-          parentSuspense,
-          false,
-          true
-        )
+        if (dynamicChildren) {
+          // fast path for block nodes: only need to unmount dynamic children.
+          unmountChildren(
+            dynamicChildren,
+            parentComponent,
+            parentSuspense,
+            false,
+            true
+          )
+        }
+
+        if (children) {
+          // #9239
+          for (let i = 0; i < (children as VNode[]).length; i++) {
+            const child = (children as VNode[])[i]
+            if (child != null && !isString(child)) {
+              unmount(child, parentComponent, parentSuspense)
+            }
+          }
+        }
       } else if (
         (type === Fragment &&
           patchFlag &
