fix: remove "browser" field in package.json (#424)

antfu · web-flow · commit 4ebeda442b1c · 2020-07-05T16:24:19.000+08:00
* fix: remove "browser" field in package.json

* fix: esm build
diff --git a/package.json b/package.json
@@ -13,7 +13,6 @@
   },
   "main": "index.js",
   "module": "dist/vue-composition-api.esm.js",
-  "browser": "dist/vue-composition-api.prod.js",
   "unpkg": "dist/vue-composition-ap.prod.js",
   "jsdelivr": "dist/vue-composition-api.prod.js",
   "typings": "dist/index.d.ts",
diff --git a/rollup.config.js b/rollup.config.js
@@ -69,9 +69,12 @@ function genConfig({ outFile, format, mode }) {
       }),
       resolve(),
       replace({
-        'process.env.NODE_ENV': JSON.stringify(
-          isProd ? 'production' : 'development'
-        ),
+        'process.env.NODE_ENV':
+          format === 'es'
+            ? // preserve to be handled by bundlers
+              'process.env.NODE_ENV'
+            : // hard coded dev/prod builds
+              JSON.stringify(isProd ? 'production' : 'development'),
         __DEV__:
           format === 'es'
             ? // preserve to be handled by bundlers
diff --git a/src/apis/inject.ts b/src/apis/inject.ts
@@ -53,7 +53,7 @@ export function inject(
     if (val !== NOT_FOUND) {
       return val
     } else {
-      if (defaultValue === undefined && process.env.NODE_ENV !== 'production') {
+      if (defaultValue === undefined && __DEV__) {
         warn(`Injection "${String(key)}" not found`, vm)
       }
       return defaultValue

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ export function inject(`
`53`	`53`	`if (val !== NOT_FOUND) {`
`54`	`54`	`return val`
`55`	`55`	`} else {`
`56`		`- if (defaultValue === undefined && process.env.NODE_ENV !== 'production') {`
	`56`	`+ if (defaultValue === undefined && __DEV__) {`
`57`	`57`	warn(`Injection "${String(key)}" not found`, vm)
`58`	`58`	`}`
`59`	`59`	`return defaultValue`