8000 chore: move disableVersionCheck to global state instead of settings by timonwong · Pull Request #773 · vscode-shellcheck/vscode-shellcheck · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move disableVersionCheck to global state instead of settings #773

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore: move disableVersionCheck to global state instead of settings #773

wants to merge 1 commit into from

Conversation

timonwong
Copy link
Member

No description provided.

@timonwong
chore: move disableVersionCheck to global state instead of settings
3952dc4 
Signed-off-by: Timon Wong <timon86.wang@gmail.com>
@timonwong timonwong marked this pull request as ready for review October 18, 2022 05:45
@timonwong timonwong requested a review from felipecrs October 18, 2022 05:45
felipecrs
felipecrs approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member
@felipecrs felipecrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just recommend adding a little bit of context to the PR description so that users would know why this is being changed.

@felipecrs felipecrs marked this pull request as draft June 6, 2023 21:02
@felipecrs
Copy link
Member

I believe it's good to keep this as a setting. Some projects may have their own shellcheck wrapper that fails this validation and may want to disable version check in the workspace settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipecrs felipecrs felipecrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timonwong @felipecrs
0