8000 fix and reformat installer by jeremy-audet · Pull Request #153 · vim-ruby/vim-ruby · GitHub
[go: up one dir, main page]

Skip to content

fix and reformat installer #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2013
Merged

fix and reformat installer #153

merged 2 commits into from
Jun 1, 2013

Conversation

jeremy-audet
Copy link
Contributor

The first of these two commits fixes a deprecation issue which prevented the installer (bin/vim-ruby-installer.rb) from running sucessfully. The second commit simply reformats the file.

Without fix, this error message appears:

    bin/vim-ruby-install.rb:15:in `<main>': Use RbConfig instead of obsolete and deprecated Config.

    uninitialized constant Env::CONFIG
    Try 'ruby bin/vim-ruby-install.rb --help' for detailed usage.
Replace tabs with spaces. Ensure comments are properly lined up with code.
AndrewRadev added a commit that referenced this pull request Jun 1, 2013
@AndrewRadev AndrewRadev merged commit 6ba4a63 into vim-ruby:master Jun 1, 2013
@AndrewRadev
Copy link
Member

I see no harm in the pull request, though maybe it's time to remove the installer altogether. I don't have enough confidence to do that, though, so if any other maintainers know what the status of the installer is, maybe now would be a good time to consider it.

Thanks for your work, in any case.

@jeremy-audet
Copy link
Contributor Author

:D

Yeah, I was surprised to see such a major issue in this package. If the installer flat-out fails, I suspect many people will not take this package seriously. No installer is better than a broken installer, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0