fix and reformat installer #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without fix, this error message appears:
bin/vim-ruby-install.rb:15:in `<main>': Use RbConfig instead of obsolete and deprecated Config.
uninitialized constant Env::CONFIG
Try 'ruby bin/vim-ruby-install.rb --help' for detailed usage.
Replace tabs with spaces. Ensure comments are properly lined up with code.
|
I see no harm in the pull request, though maybe it's time to remove the installer altogether. I don't have enough confidence to do that, though, so if any other maintainers know what the status of the installer is, maybe now would be a good time to consider it. Thanks for your work, in any case. |
|
:D Yeah, I was surprised to see such a major issue in this package. If the installer flat-out fails, I suspect many people will not take this package seriously. No installer is better than a broken installer, IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first of these two commits fixes a deprecation issue which prevented the installer (
bin/vim-ruby-installer.rb) from running sucessfully. The second commit simply reformats the file.