FFFF Fix highlight on unnamed class, struct and enum by rhysd · Pull Request #22 · vim-jp/vim-cpp · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jan 6, 2026. It is now read-only.

Fix highlight on unnamed class, struct and enum#22

Merged
mattn merged 1 commit intovim-jp:masterfrom
rhysd:fix/unamed-class-and-enum
May 16, 2014
Merged

Fix highlight on unnamed class, struct and enum#22
mattn merged 1 commit intovim-jp:masterfrom
rhysd:fix/unamed-class-and-enum

Conversation

@rhysd
Copy link
Copy Markdown
Contributor
@rhysd rhysd commented May 16, 2014

C++ では，特定のクラスから継承して匿名クラスを定義することができます．また，enum に underlying type を指定することができます．
これらの構文がラベルの構文に似ており，シンタックスハイライトはラベル部分のみのマッチで行われてしまうので誤ってラベルとしてハイライトされてしまっていました．

struct base{};

int main()
{
    //
    // Below 'enum', 'struct' and 'class' are highlighted as label
    //

    // Specify int as enum's underlying
    enum : int {} aaa;

    // unnamed derived struct
    struct : base {} bbb;

    // unnamed derived class
    class : base {} ccc;

    return 0;
}

解決策として，ラベルが struct, class, enum でないかをチェックするようにしました．

@rhysd
Fix highlight on unnamed class, struct and enum
eda6bcb 
Problem:

    In C++, unnamed derived class and struct can be defined using ':'.
    enum also can be defined with specific underlying type using ':'.
    They are highlighted as labels wrongly.

```
struct base{};

int main()
{
    //
    // Below 'enum', 'struct' and 'class' are highlighted as label
    //

    // Specify enum's underlying type
    enum : int {} aaa;

    // unnamed derived struct
    struct : base {} bbb;

    // unnamed derived class
    class : base {} ccc;

    return 0;
}
```

Solution:

    Check that labels don't match to them.
@osyo-manga
Copy link
Copy Markdown
osyo-manga commented May 16, 2014

++

@mattn
Copy link
Copy Markdown
Member
mattn commented May 16, 2014

LGTM

mattn added a commit that referenced this pull request May 16, 2014
@mattn
Merge pull request #22 from rhysd/fix/unamed-class-and-enum
ed3fc2c 
Fix highlight on unnamed class, struct and enum
@mattn mattn merged commit ed3fc2c into vim-jp:master May 16, 2014
@mattn
Copy link
Copy Markdown
Member
mattn commented May 16, 2014

Thank you

@rhysd
Copy link
Copy Markdown
Contributor Author
rhysd commented May 16, 2014

🐶 👍
8000

@mattn
Copy link
Copy Markdown
Member
mattn commented May 18, 2014

先日パッチを送ったばかりで、たて続けに送る姿勢を見せるとBramに嫌がられそうなのでしばらく時間を下さい。
すみません。

@rhysd
Copy link
Copy Markdown
Contributor Author
rhysd commented Jun 4, 2014

すみません，コメント気づいていませんでした．
パッチを送るタイミングについては @mattn さんにお任せします…！

@mattn
Copy link
Copy Markdown
Member
mattn commented Jun 4, 2014

🐕 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhysd @osyo-manga @mattn
0