8000 refactor: scene class, method names · video-db/videodb-python@09df355 · GitHub
[go: up one dir, main page]
Skip to content

Commit 09df355

Browse files
ankit-v2-3ankit-v2-3
committed
refactor: scene class, method names
1 parent ed56178 commit 09df355

File tree

2 files changed

+3
-17
lines changed

2 files changed

+3
-17
lines changed

‎videodb/scene.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,13 @@ def __init__(
1313
end: float,
1414
description: str,
1515
id: str = None,
16-
index_id: str = None,
1716
frames: List[Frame] = [],
1817
):
1918
self.id = id
2019
self.video_id = video_id
2120
self.start = start
2221
self.end = end
2322
self.frames: List[Frame] = frames
24-
self.index_id = index_id
2523
self.description = description
2624

2725
def __repr__(self) -> str:
@@ -32,7 +30,6 @@ def __repr__(self) -> str:
3230
f"start={self.start}, "
3331
f"end={self.end}, "
3432
f"frames={self.frames}, "
35-
f"index_id={self.index_id}, "
3633
f"description={self.description})"
3734
)
3835

‎videodb/video.py

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ def _format_scene_collection(self, scene_collection_data: dict) -> SceneCollecti
194194
description=scene.get("description"),
195195
id=scene.get("scene_id"),
196196
frames=frames,
197-
index_id=scene.get("index_id"),
198197
)
199198
scenes.append(scene)
200199

@@ -232,7 +231,7 @@ def get_scene_collection(self, collection_id: str):
232231
)
233232
return self._format_scene_collection(scenes_data.get("scene_collection"))
234233

235-
def get_scene_collections(self):
234+
def list_scene_collection(self):
236235
scene_collections_data = self._connection.get(
237236
path=f"{ApiPath.video}/{self.id}/{ApiPath.scenes}"
238237
)
@@ -265,18 +264,9 @@ def index_scenes(
265264
)
266265
if not scenes_data:
267266
return None
268-
return [
269-
Scene(
270-
video_id=self.id,
271-
start=scene.get("start"),
272-
end=scene.get("end"),
273-
index_id=scene.get("scene_index_id"),
274-
description=scene.get("description"),
275-
)
276-
for scene in scenes_data.get("scene_index_records", [])
277-
]
267+
return scenes_data.get("scene_index_records", [])
278268

279-
def get_scene_indexes(self) -> List:
269+
def list_scene_index(self) -> List:
280270
index_data = self._connection.get(
281271
path=f"{ApiPath.video}/{self.id}/{ApiPath.index}/{ApiPath.scene}"
282272
)
@@ -295,7 +285,6 @@ def get_scene_index(self, scene_index_id: str) -> List[Scene] or None:
295285
video_id=self.id,
296286
start=scene.get("start"),
297287
end=scene.get("end"),
298-
index_id=scene.get("scene_index_id"),
299288
description=scene.get("description"),
300289
)
301290
for scene in index_records

0 commit comments

Comments
 (0)
0