Use short-circuiting or (also may save some code size)

jepler · dhalbert · web-flow · commit a8bbb21eeb5b · 2023-03-29T10:09:01.000-05:00
Co-authored-by: Dan Halbert &lt;halbert@adafruit.com&gt;
diff --git a/shared-module/os/getenv.c b/shared-module/os/getenv.c
@@ -72,7 +72,7 @@ STATIC void close_file(file_arg *active_file) {
     // nothing
 }
 STATIC bool is_eof(file_arg *active_file) {
-    return f_eof(active_file) | f_error(active_file);
+    return f_eof(active_file) || f_error(active_file);
 }
 
 // Return 0 if there is no next character (EOF).

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ STATIC void close_file(file_arg *active_file) {`
`72`	`72`	`// nothing`
`73`	`73`	`}`
`74`	`74`	`STATIC bool is_eof(file_arg *active_file) {`
`75`		`- return f_eof(active_file) \| f_error(active_file);`
	`75`	`+ return f_eof(active_file) \|\| f_error(active_file);`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`// Return 0 if there is no next character (EOF).`