fix missing emitCheckMaxWords in Div DivS MODDIV MODDIV #6006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsnyder
reviewed
May 15, 2025
There was a problem hiding this comment.
Thanks, looks great!
Might you consider adding ideally your real name to your github profile and re-pushing this pull request? As a professional package it looks better for us, and adds good references for yourself. Alternatively, a first/last name pseudonym?
|
Of course! It's my honor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6003 by adding checks to ensure that the bit-widths of division and modulo operations meet internal constraints.