fix RequestCtx is canceled (#1879) (#1890)

ksw2000 · web-flow · commit 803c25e54ced · 2024-10-27T20:15:57.000+01:00
Create done channel in fakeServer during the initialization of newRequestCtx to prevent the done channel from being nil
diff --git a/server.go b/server.go
@@ -2789,6 +2789,7 @@ func (ctx *RequestCtx) Value(key any) any {
 }
 
 var fakeServer = &Server{
+	done: make(chan struct{}),
 	// Initialize concurrencyCh for TimeoutHandler
 	concurrencyCh: make(chan struct{}, DefaultConcurrency),
 }
diff --git a/server_test.go b/server_test.go
@@ -4414,3 +4414,13 @@ func TestRequestBodyStreamReadIssue1816(t *testing.T) {
 		t.Fatal(err)
 	}
 }
+
+func TestRequestCtxInitShouldNotBeCanceledIssue1879(t *testing.T) {
+	var r Request
+	var requestCtx RequestCtx
+	requestCtx.Init(&r, nil, nil)
+	err := requestCtx.Err()
+	if err != nil {
+		t.Fatal(err)
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -2789,6 +2789,7 @@ func (ctx *RequestCtx) Value(key any) any {`
`2789`	`2789`	`}`
`2790`	`2790`
`2791`	`2791`	`var fakeServer = &Server{`
	`2792`	`+ done: make(chan struct{}),`
`2792`	`2793`	`// Initialize concurrencyCh for TimeoutHandler`
`2793`	`2794`	`concurrencyCh: make(chan struct{}, DefaultConcurrency),`
`2794`	`2795`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4414,3 +4414,13 @@ func TestRequestBodyStreamReadIssue1816(t *testing.T) {`
`4414`	`4414`	`t.Fatal(err)`
`4415`	`4415`	`}`
`4416`	`4416`	`}`
	`4417`	`+`
	`4418`	`+func TestRequestCtxInitShouldNotBeCanceledIssue1879(t *testing.T) {`
	`4419`	`+ var r Request`
	`4420`	`+ var requestCtx RequestCtx`
	`4421`	`+ requestCtx.Init(&r, nil, nil)`
	`4422`	`+ err := requestCtx.Err()`
	`4423`	`+ if err != nil {`
	`4424`	`+ t.Fatal(err)`
	`4425`	`+ }`
	`4426`	`+}`