8000 scriptreplay: add interactive playback controls for position and speed · Issue #2999 · util-linux/util-linux · GitHub
[go: up one dir, main page]

Skip to content

scriptreplay: add interactive playback controls for position and speed #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jNullj opened this issue Apr 29, 2024 · 2 comments
Closed

scriptreplay: add interactive playback controls for position and speed #2999

jNullj opened this issue Apr 29, 2024 · 2 comments
Labels
TODO We going to think about it ;-)

Comments

@jNullj
Copy link
Contributor
jNullj commented Apr 29, 2024

The current scriptreplay utility provides a valuable tool for replaying shell scripts. However, it lacks interactive controls for playback position & speed, These could improve productivity when replaying as some recordings might have both large time-gaps that are required to be skipped while also include quick changes that require fine movement over the recording or even pausing it to read.

Additions i suggest are and key-bindings:

  • Pausing and resuming playback: space to toggle.
  • Adjusting playback speed: up/down (arrows), +/- 0.1x steps, hold for change of 0.1x/0.2 sec.
  • Stepwise navigation: left/right (arrows), hold for change of 1 step/0.2 sec.
  • Add this info and key-bindings to docs/man.
  • Optional: When paused show info about current speed, position (and last step) and pause/play state.
  • Optional: When step/playback speed changes show info about current speed, position (and last step) and pause/play state for 3 seconds.

I find myself often open the log file in an editor and scrolling as this is faster for some cases then replaying without the suggested change.

I don't mind contributing code toward this but i do want some feedback about the feasibility of this change as well as ways to improve the plan.

@karelzak
Copy link
Collaborator

Interesting idea, adding to TODO.

@karelzak karelzak added the TODO We going to think about it ;-) label Apr 29, 2024
@jNullj
Copy link
Contributor Author
jNullj commented May 31, 2024

Closing this issue as the core functionality has been implemented.

During development, it became clear that features for seeking backward are less relevant since the output is a stream. Users can navigate backward by scrolling at terminal stream/output buffer.

Optional features for displaying the current playback state are not included at this time. While these features were considered, they were deemed to have minimal impact on usability. If there's a strong desire for these features in the future, feel free to re-open this issue.

@jNullj jNullj closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO We going to think about it ;-)
Projects
None yet
Development

No branches or pull requests

2 participants
0