configure librtas check #2527

mator · 2023-10-04T21:28:21Z

mator
Oct 4, 2023

why do we have empty braces for librtas (rtas) check in configure.ac ?

I have the following error on running ./configure script with librtas-dev package installed on a debian system:

$ ./configure
...
checking for rtas_get_sysparm in -lrtas... yes
./configure: line 27623: ,: command not found
checking for struct sockaddr.sa_len... no
...

The following configure.ac code:

    717 AC_CHECK_LIB([rtas], [rtas_get_sysparm], [
    718         RTAS_LIBS="-lrtas"
    719         AC_DEFINE_UNQUOTED([HAVE_LIBRTAS], [1], [Define if librtas exists]), [],
    720 ])
    721 AC_SUBST([RTAS_LIBS])

notice the empty [] braces in the end.
I believe, we need to remove this braces:

util-linux$ git diff
diff --git a/configure.ac b/configure.ac
index 1c2cb4f0d..eb56c83ca 100644
--- a/configure.ac
+++ b/configure.ac
@@ -716,7 +716,7 @@ AS_IF([test x"$have_timer" = xno], [

 AC_CHECK_LIB([rtas], [rtas_get_sysparm], [
        RTAS_LIBS="-lrtas"
-       AC_DEFINE_UNQUOTED([HAVE_LIBRTAS], [1], [Define if librtas exists]), [],
+       AC_DEFINE_UNQUOTED([HAVE_LIBRTAS], [1], [Define if librtas exists])
 ])
 AC_SUBST([RTAS_LIBS])

removing them and running ./autogen.sh and ./configure does not produce error anymore (not depending on librtas-dev installed or not).

karelzak · 2023-10-09T11:07:23Z

karelzak
Oct 9, 2023
Maintainer

Fixed by b53ba17

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

configure librtas check #2527

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 1 comment

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

configure librtas check #2527

Uh oh!

Uh oh!

mator Oct 4, 2023

Replies: 1 comment

Uh oh!

karelzak Oct 9, 2023 Maintainer

mator
Oct 4, 2023

karelzak
Oct 9, 2023
Maintainer