libblkid: Fix crash while parsing config with libeconf

stanislav-brabec · stanislav-brabec · commit 284527cff2bd · 2025-05-16T22:19:45.000+02:00
As the whole econf_file structure is freed by econf_free(file) at the end of blkid_read_config(), econf_file structure cannot be defined as static and initialized only once. The econf_free() is not robust enough and keeps a pointer to the garbage after the first call of blkid_read_config(). And if /etc/blkid.conf does not exist, it is called second time. Signed-off-by: Stanislav Brabec <sbrabec@suse.cz> Cc: Stefan Schubert <schubi@suse.de> Link: https://bugzilla.opensuse.org/show_bug.cgi?id=1242705
diff --git a/libblkid/src/config.c b/libblkid/src/config.c
@@ -154,7 +154,7 @@ struct blkid_config *blkid_read_config(const char *filename)
 
 #else /* !HAVE_LIBECONF */
 
-	static econf_file *file = NULL;
+	econf_file *file = NULL;
 	char *line = NULL;
 	bool uevent = false;
 	econf_err error;
