8000 handle missing caller line due to throws annotation · utPLSQL/utPLSQL-SQLDeveloper@7b595cb · GitHub
[go: up one dir, main page]

Skip to content
8000

Commit 7b595cb

Browse files
handle missing caller line due to throws annotation
1 parent 266268e commit 7b595cb

File tree

1 file changed

+16
-6
lines changed

1 file changed

+16
-6
lines changed

sqldev/src/main/java/org/utplsql/sqldev/ui/runner/RunnerPanel.xtend

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ import org.utplsql.sqldev.dal.UtplsqlDao
6666
import org.utplsql.sqldev.model.LimitedLinkedHashMap
6767
import org.utplsql.sqldev.model.preference.PreferenceModel
6868
import org.utplsql.sqldev.model.runner.Run
69+
import org.utplsql.sqldev.model.runner.Test
6970
import org.utplsql.sqldev.parser.UtplsqlParser
7071
import org.utplsql.sqldev.resources.UtplsqlResources
7172
import org.utplsql.sqldev.runner.UtplsqlRunner
@@ -248,17 +249,21 @@ class RunnerPanel implements ActionListener, MouseListener, HyperlinkListener {
248249
}
249250
sorter.rowFilter = filter
250251
}
252+
253+
private def openTest(Test test) {
254+
val dao = new UtplsqlDao(Connections.instance.getConnection(currentRun.connectionName))
255+
val source = dao.getSource(test.ownerName, "PACKAGE", test.objectName.toUpperCase).trim
256+
val parser = new UtplsqlParser(source)
257+
val line = parser.getLineOf(test.procedureName)
258+
openEditor(test.ownerName, "PACKAGE", test.objectName.toUpperCase, line, 1)
259+
}
251260

252261
private def openSelectedTest() {
253262
val rowIndex = testOverviewTable.selectedRow
254263
if (rowIndex != -1) {
255264
val row = testOverviewTable.convertRowIndexToModel(rowIndex)
256265
val test = testOverviewTableModel.getTest(row)
257-
val dao = new UtplsqlDao(Connections.instance.getConnection(currentRun.connectionName))
258-
val source = dao.getSource(test.ownerName, "PACKAGE", test.objectName.toUpperCase).trim
259-
val parser = new UtplsqlParser(source)
260-
val line = parser.getLineOf(test.procedureName)
261-
openEditor(test.ownerName, "PACKAGE", test.objectName.toUpperCase, line, 1)
266+
openTest(test)
262267
}
263268
}
264269

@@ -268,7 +273,12 @@ class RunnerPanel implements ActionListener, MouseListener, HyperlinkListener {
268273
val row = failuresTable.convertRowIndexToModel(rowIndex)
269274
val expectation = failuresTableModel.getExpectation(row)
270275
val test = testOverviewTableModel.getTest(testOverviewTable.convertRowIndexToModel(testOverviewTable.selectedRow))
271-
openEditor(test.ownerName, "PACKAGE BODY", test.objectName.toUpperCase, expectation.callerLine, 1)
276+
val callerLine = expectation.callerLine
277+
if (callerLine !== null) {
278+
openEditor(test.ownerName, "PACKAGE BODY", test.objectName.toUpperCase, expectation.callerLine, 1)
279+
} else {
280+
openTest(test)
281+
}
272282
}
273283
}
274284

0 commit comments

Comments
 (0)
0