From 48505fbe05364660b65fca7e6934a652e4b74a03 Mon Sep 17 00:00:00 2001
From: Jacek Gebal <jgebal@users.noreply.github.com>
Date: Mon, 17 Oct 2022 18:28:38 +0300
Subject: [PATCH 1/2] Adding support for long type names in tests. Resolves:
 #1235

---
 .../data_values/ut_cursor_details.tpb             |  4 ++++
 .../expectations/test_expectation_anydata.pkb     | 15 +++++++++++++++
 .../expectations/test_expectation_anydata.pks     |  6 ++++++
 3 files changed, 25 insertions(+)

diff --git a/source/expectations/data_values/ut_cursor_details.tpb b/source/expectations/data_values/ut_cursor_details.tpb
index adc705f65..b823ff944 100644
--- a/source/expectations/data_values/ut_cursor_details.tpb
+++ b/source/expectations/data_values/ut_cursor_details.tpb
@@ -91,7 +91,11 @@ create or replace type body ut_cursor_details as
     a_cursor_number in number
   ) return self as result is
     l_columns_count    pls_integer;
+    $if dbms_db_version.version = 12 and dbms_db_version.release = 1 or dbms_db_version.version < 12 $then
     l_columns_desc     dbms_sql.desc_tab3;
+    $else
+    l_columns_desc     dbms_sql.desc_tab4;
+    $end
     l_is_collection    boolean;
     l_hierarchy_level  integer := 1;
   begin
diff --git a/test/ut3_user/expectations/test_expectation_anydata.pkb b/test/ut3_user/expectations/test_expectation_anydata.pkb
index 98938c107..bbac14ea2 100644
--- a/test/ut3_user/expectations/test_expectation_anydata.pkb
+++ b/test/ut3_user/expectations/test_expectation_anydata.pkb
@@ -1211,5 +1211,20 @@ Rows: [ 60 differences, showing first 20 ]
 	ut.expect(ut3_tester_helper.main_helper.get_failed_expectations_num).to_equal(0);
 
   end;  
+
+  $if dbms_db_version.version = 12 and dbms_db_version.release >= 2 or dbms_db_version.version > 12 $then
+  procedure long_names_object_types is
+    pragma autonomous_transaction;
+  begin
+    execute immediate 'create or replace type tp_r_ug_sportsman_invitation_result is object ( code number(18) )';
+    execute immediate 'begin ut.expect(anydata.convertObject(tp_r_ug_sportsman_invitation_result(1))).to_equal(anydata.convertObject(tp_r_ug_sportsman_invitation_result(1))); end;';
+    execute immediate 'drop type tp_r_ug_sportsman_invitation_result';
+  exception
+    when others then
+    execute immediate 'drop type tp_r_ug_sportsman_invitation_result';
+    raise;
+  end;
+  $end
+
 end;
 /
\ No newline at end of file
diff --git a/test/ut3_user/expectations/test_expectation_anydata.pks b/test/ut3_user/expectations/test_expectation_anydata.pks
index 2abb48b7f..81dea74eb 100644
--- a/test/ut3_user/expectations/test_expectation_anydata.pks
+++ b/test/ut3_user/expectations/test_expectation_anydata.pks
@@ -233,5 +233,11 @@ create or replace package test_expectation_anydata is
   
   --%test ( Reports success when comparing complex nested objects )
   procedure complex_nested_object_success;      
+
+  $if dbms_db_version.version = 12 and dbms_db_version.release >= 2 or dbms_db_version.version > 12 $then
+  --%test ( Compares object types with long names - Issue #1235 )
+  procedure long_names_object_types;
+  $end
+
 end;
 /

From 1eb52e1e209945477c4066004cdd2f5293290297 Mon Sep 17 00:00:00 2001
From: Jacek Gebal <jgebal@users.noreply.github.com>
Date: Mon, 17 Oct 2022 20:33:42 +0300
Subject: [PATCH 2/2] Fixing unit test - needs to use ut3_develop sourcecode in
 test.

---
 .../expectations/test_expectation_anydata.pkb | 20 +++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/test/ut3_user/expectations/test_expectation_anydata.pkb b/test/ut3_user/expectations/test_expectation_anydata.pkb
index bbac14ea2..c56c31930 100644
--- a/test/ut3_user/expectations/test_expectation_anydata.pkb
+++ b/test/ut3_user/expectations/test_expectation_anydata.pkb
@@ -1216,12 +1216,24 @@ Rows: [ 60 differences, showing first 20 ]
   procedure long_names_object_types is
     pragma autonomous_transaction;
   begin
-    execute immediate 'create or replace type tp_r_ug_sportsman_invitation_result is object ( code number(18) )';
-    execute immediate 'begin ut.expect(anydata.convertObject(tp_r_ug_sportsman_invitation_result(1))).to_equal(anydata.convertObject(tp_r_ug_sportsman_invitation_result(1))); end;';
-    execute immediate 'drop type tp_r_ug_sportsman_invitation_result';
+    execute immediate q'[create or replace type
+      very_long_type_name_valid_for_oracle_12_so_utPLSQL_should_allow_it_definitely_well_still_not_reached_128_but_wait_we_did_it
+      is object (
+        code number(18)
+      )]';
+    execute immediate q'[
+      begin
+        ut3_develop.ut.expect(anydata.convertObject(
+          very_long_type_name_valid_for_oracle_12_so_utPLSQL_should_allow_it_definitely_well_still_not_reached_128_but_wait_we_did_it(1)
+        )).to_equal(anydata.convertObject(
+          very_long_type_name_valid_for_oracle_12_so_utPLSQL_should_allow_it_definitely_well_still_not_reached_128_but_wait_we_did_it(1)
+        ));
+      end;]';
+    ut.expect(ut3_tester_helper.main_helper.get_failed_expectations_num).to_equal(0);
+    execute immediate 'drop type very_long_type_name_valid_for_oracle_12_so_utPLSQL_should_allow_it_definitely_well_still_not_reached_128_but_wait_we_did_it';
   exception
     when others then
-    execute immediate 'drop type tp_r_ug_sportsman_invitation_result';
+    execute immediate 'drop type very_long_type_name_valid_for_oracle_12_so_utPLSQL_should_allow_it_definitely_well_still_not_reached_128_but_wait_we_did_it';
     raise;
   end;
   $end