Fixed issue with port "0" returning None

imkaka · web-flow · commit 25fbd5fb72ae · 2022-12-30T14:08:50.000-06:00
diff --git a/src/urllib3/util/url.py b/src/urllib3/util/url.py
@@ -63,7 +63,7 @@
 BRACELESS_IPV6_ADDRZ_RE = re.compile("^" + IPV6_ADDRZ_PAT[2:-2] + "$")
 ZONE_ID_RE = re.compile("(" + ZONE_ID_PAT + r")\]$")
 
-_HOST_PORT_PAT = ("^(%s|%s|%s)(?::0*([0-9]{0,5}))?$") % (
+_HOST_PORT_PAT = ("^(%s|%s|%s)(?::0*?(|0|[1-9][0-9]{0,4}))?$") % (
     REG_NAME_PAT,
     IPV4_PAT,
     IPV6_ADDRZ_PAT,
diff --git a/test/test_util.py b/test/test_util.py
@@ -351,6 +351,13 @@ def test_parse_url_remove_leading_zeros(self):
         url = parse_url("https://example.com:0000000000080")
         assert url.port == 80
 
+    def test_parse_url_only_zeros(self):
+        url = parse_url("https://example.com:0")
+        assert url.port == 0
+
+        url = parse_url("https://example.com:000000000000")
+        assert url.port == 0
+
     def test_Url_str(self):
         U = Url("http", host="google.com")
         assert str(U) == U.url
