Merge pull request #1439 from hmiyado/fix-timestamp-getvalue

meatballhat · web-flow · commit c8147a48450b · 2022-07-20T07:57:52.000-04:00
Fix timestamp flag error when using help

--

I'm merging this with the codecov patch check failing because this fixes a bug in code that wasn't sufficiently covered prior to the fix. In other words, I don't consider this codecov failure to be specific to this PR.
diff --git a/flag_timestamp.go b/flag_timestamp.go
@@ -90,7 +90,7 @@ func (f *TimestampFlag) GetCategory() string {
 // GetValue returns the flags value as string representation and an empty
 // string if the flag takes no value at all.
 func (f *TimestampFlag) GetValue() string {
-	if f.Value != nil {
+	if f.Value != nil && f.Value.timestamp != nil {
 		return f.Value.timestamp.String()
 	}
 	return ""

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ func (f *TimestampFlag) GetCategory() string {`
`90`	`90`	`// GetValue returns the flags value as string representation and an empty`
`91`	`91`	`// string if the flag takes no value at all.`
`92`	`92`	`func (f *TimestampFlag) GetValue() string {`
`93`		`- if f.Value != nil {`
	`93`	`+ if f.Value != nil && f.Value.timestamp != nil {`
`94`	`94`	`return f.Value.timestamp.String()`
`95`	`95`	`}`
`96`	`96`	`return ""`