8000 finiseh sumAll · unconnect/javascript-exercises@aef6673 · GitHub
[go: up one dir, main page]

Skip to content

Commit aef6673

Browse files
committed
finiseh sumAll
1 parent 2929c48 commit aef6673

File tree

2 files changed

+27
-6
lines changed

2 files changed

+27
-6
lines changed

05_sumAll/sumAll.js

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,26 @@
1-
const sumAll = function() {
1+
const sumAll = function(number1, number2) {
22

3+
// Check for smaller 0 or not-a-number
4+
if (number1 < 0 || number2 < 0 || typeof number1 !== 'number' || typeof number2 !== 'number') {
5+
return 'ERROR';
6+
}
7+
8+
// Checks for larger number first and swiches them
9+
if(number1 > number2) {
10+
let dummy = number2;
11+
number2 = number1;
12+
number1 = dummy;
13+
}
14+
15+
let sum = 0;
16+
let index = number1;
17+
18+
while (index <= number2) {
19+
sum += index;
20+
index++;
21+
}
22+
23+
return sum;
324
};
425

526
// Do not edit below this line

05_sumAll/sumAll.spec.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,19 @@ describe('sumAll', () => {
44
test('sums numbers within the range', () => {
55
expect(sumAll(1, 4)).toEqual(10);
66
});
7-
test.skip('works with large numbers', () => {
7+
test('works with large numbers', () => {
88
expect(sumAll(1, 4000)).toEqual(8002000);
99
});
10-
test.skip('works with larger number first', () => {
10+
test('works with larger number first', () => {
1111
expect(sumAll(123, 1)).toEqual(7626);
1212
});
13-
test.skip('returns ERROR with negative numbers', () => {
13+
test('returns ERROR with negative numbers', () => {
1414
expect(sumAll(-10, 4)).toEqual('ERROR');
1515
});
16-
test.skip('returns ERROR with non-number parameters', () => {
16+
test('returns ERROR with non-number parameters', () => {
1717
expect(sumAll(10, "90")).toEqual('ERROR');
1818
});
19-
test.skip('returns ERROR with non-number parameters', () => {
19+
test('returns ERROR with non-number parameters', () => {
2020
expect(sumAll(10, [90, 1])).toEqual('ERROR');
2121
});
2222
});

0 commit comments

Comments
 (0)
0