avoid duplicate done calls when rendering complete message

yyx990803 · yyx990803 · commit 5c3554071687 · 2016-04-09T02:38:01.000-04:00
diff --git a/lib/generate.js b/lib/generate.js
@@ -44,12 +44,7 @@ module.exports = function generate (name, src, dest, done) {
     .destination(dest)
     .build(function (err) {
       done(err)
-      if (opts.completeMessage) {
-        formatMessage(opts.completeMessage, data, function (err, message) {
-          if (err) return done(err)
-          console.log(message)
-        })
-      }
+      logMessage(opts.completeMessage, data)
     })
 }
 
@@ -105,18 +100,22 @@ function renderTemplateFiles (files, metalsmith, done) {
 }
 
 /**
- * Format complete message.
+ * Display template complete message.
  *
  * @param {String} message
  * @param {Object} data
  * @param {Function} cb
  */
 
-function formatMessage (message, data, cb) {
+function logMessage (message, data) {
+  if (!message) return
   render(message, data, function (err, res) {
-    if (err) return cb(err)
-    cb(null, '\n' + res.split(/\r?\n/g).map(function (line) {
-      return '   ' + line
-    }).join('\n'))
+    if (err) {
+      console.error('\n   Error when rendering template complete message: ' + err.message.trim())
+    } else {
+      console.log('\n' + res.split(/\r?\n/g).map(function (line) {
+        return '   ' + line
+      }).join('\n'))
+    }
   })
 }
