bpo-31664: Fix test_crypt for the openwall implementation of crypt. (python#4116)

serhiy-storchaka · web-flow · commit 0f261583bae7 · 2017-10-25T16:30:13.000+03:00
diff --git a/Lib/test/test_crypt.py b/Lib/test/test_crypt.py
@@ -57,7 +57,13 @@ def test_log_rounds(self):
     def test_invalid_log_rounds(self):
         for log_rounds in (1, -1, 999):
             salt = crypt.mksalt(crypt.METHOD_BLOWFISH, log_rounds=log_rounds)
-            self.assertIsNone(crypt.crypt('mypassword', salt))
+            cr = crypt.crypt('mypassword', salt)
+            if cr is not None:
+                # On failure the openwall implementation returns a magic
+                # string that is shorter than 13 characters and is guaranteed
+                # to differ from a salt.
+                self.assertNotEqual(cr, salt)
+                self.assertLess(len(cr), 13)
 
 
 if __name__ == "__main__":
