Fix SerialUART::overflow reporting race condition (earlephilhower#1133)

earlephilhower · web-flow · commit ecaa2bd778eb · 2023-01-21T01:38:15.000-08:00
Fixes earlephilhower#1132
diff --git a/cores/rp2040/SerialUART.cpp b/cores/rp2040/SerialUART.cpp
@@ -289,13 +289,22 @@ int SerialUART::read() {
 }
 
 bool SerialUART::overflow() {
-    CoreMutex m(&_mutex);
-    if (!_running || !m) {
+    if (!_running) {
         return false;
     }
-    bool hold = _overflow;
+
+    if (_polling) {
+        _handleIRQ(false);
+    } else {
+        _pumpFIFO();
+    }
+
+    mutex_enter_blocking(&_fifoMutex);
+    bool ovf = _overflow;
     _overflow = false;
-    return hold;
+    mutex_exit(&_fifoMutex);
+
+    return ovf;
 }
 
 int SerialUART::available() {
