Merge pull request webpack#8401 from shahkashani/fix-for-issue-8398

sokra · web-flow · commit ccc7db79bab2 · 2018-12-30T18:28:48.000+01:00
Fix for webpack#8398 - call failed-hook on compilation errors
diff --git a/lib/Compiler.js b/lib/Compiler.js
@@ -207,6 +207,10 @@ class Compiler extends Tapable {
 		const finalCallback = (err, stats) => {
 			this.running = false;
 
+			if (err) {
+				this.hooks.failed.call(err);
+			}
+
 			if (callback !== undefined) return callback(err, stats);
 		};
 
diff --git a/test/Compiler.test.js b/test/Compiler.test.js
@@ -493,4 +493,25 @@ describe("Compiler", () => {
 			});
 		});
 	});
+	it("should call the failed-hook on error", done => {
+		const failedSpy = jest.fn();
+		const compiler = webpack({
+			bail: true,
+			context: __dirname,
+			mode: "production",
+			entry: "./missing",
+			output: {
+				path: "/",
+				filename: "bundle.js"
+			},
+		});
+		compiler.hooks.failed.tap('CompilerTest', failedSpy);
+		compiler.outputFileSystem = new MemoryFs();
+		compiler.run((err, stats) => {
+			expect(err).toBeTruthy();
+			expect(failedSpy).toHaveBeenCalledTimes(1);
+			expect(failedSpy).toHaveBeenCalledWith(err);
+			done();
+		});
+	});
 });
