10000 docs: update main with v8 blog post changes by kirkwaiblinger · Pull Request #9365 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]

Skip to content

docs: update main with v8 blog post changes #9365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kirkwaiblinger
Copy link
Member
@kirkwaiblinger kirkwaiblinger commented Jun 15, 2024

PR Checklist

Overview

Copies the changes from #9102 to main.

ran git restore packages/website/blog/2024-05-27-announcing-typescript-eslint-v8-beta.mdx --source=v8 to just grab the current state of the file on that branch (which at the time of writing is strictly ahead of main, so this shouldn't be overwriting any subsequent changes on main -- this should probably be double-checked before merging though).

UPDATE - also fixed a few relative paths to absolute paths for nonexistent links on main

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link
netlify bot commented Jun 15, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d2f7137
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66705b9b3adb430008e3664a
😎 Deploy Preview https://deploy-preview-9365--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirkwaiblinger kirkwaiblinger changed the title docs: update main with v8 blog post changes. docs: update main with v8 blog post changes Jun 15, 2024
Copy link
nx-cloud bot commented Jun 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d2f7137. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

10000

Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 16, 2024
@kirkwaiblinger kirkwaiblinger requested a review from a team June 16, 2024 16:16
@kirkwaiblinger
Copy link
Member Author
kirkwaiblinger commented Jun 16, 2024

Requesting a review from a second member of @typescript-eslint/triage-team in order to merge soon 🙏, since this specific PR has the potential to go stale quickly (i.e. pick up conflicting changes) if further changes to the blog post get merged into either main or v8 in the meantime

Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked privately - the 1 approval label is kinda vague now. But +1 to this getting merged soon so it ships in our regular release!

@kirkwaiblinger kirkwaiblinger merged commit 911240b into typescript-eslint:main Jun 17, 2024
62 checks passed
@kirkwaiblinger kirkwaiblinger deleted the sync-v8-blog-post branch June 17, 2024 16:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0