8000
We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This adds private field support to prefer-readonly with the same behaviour as for classic TS private properties.
prefer-readonly
The tests are just duplicates of the existing tests, but with private name replaced with #name.
private name
#name
Sorry, something went wrong.
Add private field support to prefer-readonly
63e1d59
Fix change in prefer-readonly docs
d315bf9
Thanks for the PR, @Jamesernator!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
Thanks again!
🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.
To edit notification comments on pull requests, go to your Netlify site configuration.
CI is running/has finished running commands for commit 7dd8f6b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
nx test eslint-plugin --coverage=false
nx test scope-manager --coverage=false
nx run types:build
nx test type-utils --coverage=false
nx test visitor-keys --coverage=false
nx run repo-tools:postinstall-script
nx test rule-schema-to-typescript-types --coverage=false
nx test utils --coverage=false
nx test typescript-estree --coverage=false
nx test parser --coverage=false
nx test eslint-plugin-internal --coverage=false
nx test ast-spec --coverage=false
nx test eslint-plugin-tslint --coverage=false
nx test repo-tools --coverage=false
nx run-many --target=typecheck --parallel
nx run-many --target=lint --parallel
nx run integration-tests:test
nx run eslint-plugin:generate:configs
nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
Sent with 💌 from NxCloud.
Restore missing test
0400de5
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
+5/-1 in implementation +907 in tests
Love it 😂. Super thorough tests - nicely done! 👏
Just requesting changes on a bit of docs too please. Thanks!
👋 Hey @Jamesernator! Just checking in, is this still something you have time for? No worries if not - I just don't want to leave it hanging.
Update docs to mention private fields
7ffcccc
I've added a small docs change to mention it now affects both typescript private modifiers and private fields.
private
Merge remote-tracking branch 'upstream/main' into prefer-readonly-pri…
34151ee
…vate-fields
Great thanks! If you re-request review through the GitHub UI we'll be notified to take a look. Otherwise we don't always go back to PRs.
Awesome, thanks! The tests are just as awesomely thorough as before. 🚀
397cb60
Update packages/eslint-plugin/docs/rules/prefer-readonly.md
Merge branch 'main' into prefer-readonly-private-fields
c11278c
4afce49
7dd8f6b
0e875bf
JoshuaKGoldberg JoshuaKGoldberg left review comments
Successfully merging this pull request may close these issues.