8000 feat(eslint-plugin): add new rule restrict-plus-operands by armano2 · Pull Request #70 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

feat(eslint-plugin): add new rule restrict-plus-operands #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 22, 2019
Merged

feat(eslint-plugin): add new rule restrict-plus-operands #70

merged 9 commits into from
Jan 22, 2019

Conversation

armano2
Copy link
Collaborator
@armano2 armano2 commented Jan 18, 2019 •
edited
Loading

This PR implement rule restrict-plus-operands

  • implement rule
  • add tests
  • add documentation

continuation of bradzacher/eslint-plugin-typescript#230

@armano2 armano2 added the DO NOT MERGE PRs which should not be merged yet label Jan 18, 2019
@bradzacher
Copy link
Member

(shouldn't this be a feat?)

@armano2 armano2 changed the title fix(plugin-typescript): Add rule restrict-plus-operands feat(plugin-typescript): Add rule restrict-plus-operands Jan 18, 2019
@armano2
Copy link
Collaborator Author
armano2 commented Jan 18, 2019 •
edited
Loading

it should

i have some concerns about performance for now, i will have to digg in a little to check if this is not related to ts-estree

@armano2 armano2 self-assigned this Jan 19, 2019
@JamesHenry
Copy link
Member

I think looking to land this after the first release would be best 👍

@armano2 armano2 changed the title feat(plugin-typescript): Add rule restrict-plus-operands feat(eslint-plugin): add new rule restrict-plus-operands Jan 20, 2019
@armano2 armano2 added enhancement: new plugin rule New rule request for eslint-plugin and removed DO NOT MERGE PRs which should not be merged yet labels Jan 20, 2019
JamesHenry
JamesHenry requested changes Jan 21, 2019
View reviewed changes
Copy link
Member
@JamesHenry JamesHenry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that v1 is out the door we can consider merging this.

@armano2 Can you elaborate on the performance concerns, and what has changed since you first opened the PR?

@armano2
Copy link
Collaborator Author
armano2 commented Jan 21, 2019 •
edited
Loading

i did profiling on this rule, and there is no performance impact generated by our code, TypeCheker is not fast, and most likely there is some room to improve it in ts-estree, but i didn't found any direct issue in this rule

@JamesHenry
Copy link
Member

Ok great, thanks

@codecov
Copy link
codecov bot commented Jan 22, 2019

Codecov Report

Merging #70 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   95.01%   95.14%   +0.12%     
==========================================
  Files          48       49       +1     
  Lines        2487     2512      +25     
  Branches      382      382              
==========================================
+ Hits         2363     2390      +27     
+ Misses         75       73       -2     
  Partials       49       49
Impacted Files Coverage Δ
.../eslint-plugin/lib/rules/restrict-plus-operands.js 100% <100%> (ø)
packages/eslint-plugin/lib/util.js 97.22% <0%> (+5.55%) ⬆️

@JamesHenry JamesHenry merged commit c541ede into typescript-eslint:master Jan 22, 2019
@armano2 armano2 deleted the restrict-plus-operands branch January 22, 2019 17:13
@kachkaev kachkaev mentioned this pull request Mar 28, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j-f1 j-f1 j-f1 left review comments

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees

@armano2 armano2

Labels
enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armano2 @bradzacher @JamesHenry @j-f1
0