feat(typescript-estree): cache project glob resolution #6367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
245edda to
9226a45
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6367 +/- ##
==========================================
+ Coverage 91.38% 91.40% +0.01%
==========================================
Files 368 370 +2
Lines 12608 12652 +44
Branches 3713 3723 +10
==========================================
+ Hits 11522 11564 +42
- Misses 770 771 +1
- Partials 316 317 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7 tasks
JoshuaKGoldberg
requested changes
Jan 25, 2023
packages/typescript-estree/src/parseSettings/resolveProjectList.ts
Outdated
Show resolved
Hide resolved
packages/typescript-estree/src/parseSettings/resolveProjectList.ts
Outdated
Show resolved
Hide resolved
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Whilst reviewing #6084 I realised we could save some time in the parser by caching the
parserOptions.projectglob resolution results. So I spent a bit of time throwing this together.I tested this locally and it saved a little bit of time (~1 second) because our glob is so small (we use
packages/*/tsconfig.json- which only matches 15 folders.Though it's still eye-opening to see that the tiny globbing for our repo adds up to an entire second.
I double checked these results by taking a CPU profile before and after:
$ TSESTREE_SINGLE_RUN=true node --cpu-prof ./node_modules/.bin/eslint .Then I inspected the profiles on https://speedscope.app
For reference - the profiles: PROFILES.zip
Before change:
After change:
I would expect that this change should show a large perf improvement in the following cases:
packages/*/tsconfig.jsonon something the size of babel's packages folder or bigger)['foo/*/tsconfig.json', 'bar/*/tsconfig.json', 'baz/*/tsconfig.json', ...])