8000 fix(eslint-plugin)!: remove "isTypescriptFile". by sosukesuzuki · Pull Request #594 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

fix(eslint-plugin)!: remove "isTypescriptFile". #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 21, 2019
Merged

fix(eslint-plugin)!: remove "isTypescriptFile". #594

merged 6 commits into from
Jul 21, 2019

Conversation

sosukesuzuki
Copy link
Contributor
@sosukesuzuki sosukesuzuki commented Jun 6, 2019 •
edited by bradzacher
Loading

BREAKING CHANGE

Resolve #524

Remove isTypescriptFile to make some typescript-eslint rules compate with files are not .ts or .tsx(e.g. .vue).

@codecov
Copy link
codecov bot commented Jun 6, 2019 •
edited
Loading

Codecov Report

Merging #594 into master will increase coverage by 0.03%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
+ Coverage   94.41%   94.45%   +0.03%     
==========================================
  Files         113      113              
  Lines        4711     4705       -6     
  Branches     1293     1288       -5     
==========================================
- Hits         4448     4444       -4     
  Misses        150      150              
+ Partials      113      111       -2
Impacted Files Coverage Δ
packages/eslint-plugin/src/util/misc.ts 84.21% <ø> (+3.25%) ⬆️
...-plugin/src/rules/explicit-function-return-type.ts 100% <100%> (ø) ⬆️
...-plugin/src/rules/explicit-member-accessibility.ts 89.58% <78.94%> (+1.34%) ⬆️

@bradzacher bradzacher added the breaking change This change will require a new major version to be released label Jun 6, 2019
@bradzacher bradzacher mentioned this pull request Jun 6, 2019
Closed
14 tasks
@sosukesuzuki
Copy link
Contributor Author

@bradzacher Sorry, I considered to pass the CodeCov, but I did not know what to do. Should probably I add some tests?

bradzacher
bradzacher previously approved these changes Jun 10, 2019
View reviewed changes
@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 10, 2019
JamesHenry
JamesHenry previously requested changes Jun 20, 2019
View reviewed changes
@JamesHenry
Copy link
Member

Just the one update, then we can merge this. Thanks @sosukesuzuki!

@bradzacher bradzacher added this to the 2.0.0 milestone Jun 28, 2019
@bradzacher bradzacher added the bug Something isn't working label Jun 28, 2019
@IlCallo IlCallo mentioned this pull request Jul 15, 2019
Closed
@bradzacher bradzacher changed the title fix(eslint-plugin): remove "isTypescriptFile". fix(eslint-plugin)!: remove "isTypescriptFile". Jul 21, 2019
@JamesHenry JamesHenry merged commit 4933ade into typescript-eslint:master Jul 21, 2019
@sosukesuzuki sosukesuzuki deleted the remove-istypescriptfile branch August 12, 2019 04:28
@bradzacher bradzacher mentioned this pull request Aug 27, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge breaking change This change will require a new major version to be released bug Something isn't working
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Make typescript-eslint rules compatible with .vue files
3 participants
@sosukesuzuki @JamesHenry @bradzacher
0