From 9ec224025838469d5a4492af183ffe88f96dc258 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Mon, 17 Oct 2022 10:22:19 -0400 Subject: [PATCH 1/2] fix(eslint-plugin): [no-base-to-string] ignore Error, URL, and URLSearchParams by default --- packages/eslint-plugin/src/rules/no-base-to-string.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/eslint-plugin/src/rules/no-base-to-string.ts b/packages/eslint-plugin/src/rules/no-base-to-string.ts index 8c81878238fa..8b8521491f2c 100644 --- a/packages/eslint-plugin/src/rules/no-base-to-string.ts +++ b/packages/eslint-plugin/src/rules/no-base-to-string.ts @@ -48,7 +48,7 @@ export default util.createRule({ }, defaultOptions: [ { - ignoredTypeNames: ['RegExp'], + ignoredTypeNames: ['Error', 'RegExp', 'URL', 'URLSearchParams'], }, ], create(context, [option]) { From 479ab5bf8a995117f49f31a5715a5b8648a88e85 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Mon, 17 Oct 2022 10:24:59 -0400 Subject: [PATCH 2/2] Added tests --- packages/eslint-plugin/tests/rules/no-base-to-string.test.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts b/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts index a60ac656a40e..c8af0c48ad83 100644 --- a/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts +++ b/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts @@ -113,6 +113,9 @@ tag\`\${{}}\`; return \`\${v}\`; } `, + "'' += new Error();", + "'' += new URL();", + "'' += new URLSearchParams();", ], invalid: [ {