docs: fleshed out dedicated Architecture section #4124
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
|
✔️ Deploy Preview for typescript-eslint ready! 🔨 Explore the source changes: 26d20b0 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61906420e40c610007885e2b 😎 Browse the preview: https://deploy-preview-4124--typescript-eslint.netlify.app |
Nx Cloud ReportCI ran the following commands for commit 26d20b0. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
Co-authored-by: Armano <armano2@users.noreply.github.com>
docs/development/CUSTOM_RULES.md
Outdated
| create(context) { | ||
| return { | ||
| TSInterfaceDeclaration(node) { | ||
| if (/\p{Lu}/.test(node.id.name[0])) { |
There was a problem hiding this comment.
Wait - what is this regex style? Shouldn't it be /[a-z]/?
There was a problem hiding this comment.
https://unicode.org/reports/tr18/#General_Category_Property
...except, I'm finding it to not be working in my dev tools, so I'll just go ahead and switch.
There was a problem hiding this comment.
TIL - i'd never seen it before!
I never mess with unicode though heh
There was a problem hiding this comment.
another way to do this which would let it work independent of latin characters is
if (node.id.name[0].toUpperCase() === node.id.name[0]) {But it's a bit more obtuse for people to understand in a tutorial...!
come on dictionary - it was added to oxford in 2018 - https://english.stackexchange.com/a/246562 |
PR Checklist
Overview
Creates a
Developmentsection with sub-sections forArchitectureandCustom Rules.A few organizational touchups:
Guidesshorthand section (since everything there is a guide at the moment)Development > ArchitectureWas there anything else we should cover for third-party folks writing their own plugins?