-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(eslint-plugin): [prom-func-async] add automatic fix #2845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [prom-func-async] add automatic fix #2845
Conversation
Thanks for the PR, @phaux! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2845 +/- ##
==========================================
- Coverage 92.75% 92.75% -0.01%
==========================================
Files 309 309
Lines 10335 10345 +10
Branches 2927 2931 +4
==========================================
+ Hits 9586 9595 +9
Misses 346 346
- Partials 403 404 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Nevermind. This PR only adds auto fix and ignores abstract methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for your contribution!
I use this rule a lot so I added an automatic fix for it.