8000 Repo: CI runs on `main` commits are being cancelled if a new commit lands before CI completes · Issue #8773 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Repo: CI runs on main commits are being cancelled if a new commit lands before CI completes #8773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradzacher opened this issue Mar 25, 2024 · 3 comments · Fixed by #8828
Closed

Repo: CI runs on main commits are being cancelled if a new commit lands before CI completes #8773

bradzacher opened this issue Mar 25, 2024 · 3 comments · Fixed by #8828
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@bradzacher
Copy link
Member

Suggestion

#7819

This PR added concurrency config for our actions. This is great for branch (PR) CI runs as it ensures we don't keep CI runs on old commits if a new commit comes in. So if a user spans a bunch of pushes then we'll only have one run per PR.

However the config also applies to main - which is a problem. We rely on the main CI to validate each commit is correct. We also rely on it to publish a canary version per commit.

This has lead us into this state:

Screenshot of man's history

We currently have a breakage in the website caused by a semantic merge conflict.
However we have no idea what commit caused the problem because so many commits have had their CI cancelled.

We need to exclude main from this concurrency config.
@bradzacher bradzacher added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels Mar 25, 2024
@JoshuaKGoldberg
Copy link
Member

Related / byproduct: #8774 -> #8775.

@JoshuaKGoldberg
Copy link
Member
JoshuaKGoldberg commented Mar 25, 2024 •
edited
Loading

Hmm, https://docs.github.com/en/actions/using-jobs/using-concurrency isn't promising.

Maybe we should enable the dreaded require branches be up to date option for PRs?

@bradzacher
Copy link
Member Author

https://docs.github.com/en/actions/using-jobs/using-concurrency#example-only-cancel-in-progress-jobs-on-specific-branches

Looks like you can use conditions in the flag so we can disable the cancelling just on the main branch.

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: ${{ !contains(github.ref, 'release/')}}

@tarunrajput tarunrajput mentioned this issue Apr 3, 2024
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
@bradzacher bradzacher added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: disable cancelling concurrent workflow runs on main tarunrajput/typescript-eslint
2 participants
@JoshuaKGoldberg @bradzacher
0