8000 Bug: [no-shadow] 'T' in static method is already declared in upper scope when class is in a factory function · Issue #7664 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Bug: [no-shadow] 'T' in static method is already declared in upper scope when class is in a factory function #7664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
yifanwww opened this issue Sep 17, 2023 · 1 comment · Fixed by #7724
Closed
4 tasks done

Bug: [no-shadow] 'T' in static method is already declared in upper scope when class is in a factory function #7664

yifanwww opened this issue Sep 17, 2023 · 1 comment · Fixed by #7724
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@yifanwww
Copy link
yifanwww commented Sep 17, 2023 •
edited
Loading

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.2.2&fileType=.tsx&code=GYVwdgxgLglg9mABAWwIYGsCmBBAFASkQG8BYAKEUQCdMoQqkIAbVAZ1cWwB4AVAPmLlKlCAlZQqIaHCq4ADiABGTGBEQA3VExCYAXIh6EiiAL7khw8alhq0WXn1ybteg0YvDqtekjCYA7pwOTlo6%2BADcHqYWZmSx5KJg4pyIALwoGDgE5EA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1uQAsBDACYcA7uiiJo0DtEjgwAXxDygA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

function makeA() {
  return class A<T> {
    constructor(public value: T) { }

    static make<T>(value: T) {
      return new A<T>(value);
    }
  }
}

const A = makeA()

ESLint Config

module.exports = {
  parser: "@typescript-eslint/parser",
  rules: {
    "@typescript-eslint/no-shadow": "error",
  },
};

Expected Result

No lint errors.

Actual Result

'T' is already declared in the upper scope on line 2 column 18. 5:17 - 5:18

Additional Info

No response
@yifanwww yifanwww added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Sep 17, 2023
@bradzacher
Copy link
Member
bradzacher commented Sep 17, 2023 •
edited
Loading

This was fixed back in #3393 but it appears that only handled class declarations, not class expressions.

@bradzacher bradzacher added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Sep 17, 2023
@peanutenthusiast peanutenthusiast mentioned this issue Oct 5, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
2 participants
@bradzacher @yifanwww
0