8000 Bug: [no-restricted-imports] allowTypeImports allows side effect imports · Issue #7559 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Bug: [no-restricted-imports] allowTypeImports allows side effect imports #7559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
joshkel opened this issue Aug 29, 2023 · 0 comments · Fixed by #7560
Closed
4 tasks done

Bug: [no-restricted-imports] allowTypeImports allows side effect imports #7559

joshkel opened this issue Aug 29, 2023 · 0 comments · Fixed by #7560
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look

Comments

@joshkel
Copy link
Contributor
joshkel commented Aug 29, 2023

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.2.2&fileType=.tsx&code=JYWwDg9gTgLgBAIgGYQgg3AKFJWcYCeYApnAN5wBiqcAvnElBCIimljtPBYSXAEIBDKHQZMWyVBmzgu5AYIBeoxs1ZT0QA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1uhXyrPyIAJrUoBbYh2j5UGANqRE0aFMgAaTOGw5iAQ3wALWWDlbtELOe2QmusYnRQAZhw7qzVqLvjwOAdwAVEkQASQkpGUc%2BWEQPbQBfOLAAXQ941IhE%2BKA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

import "foo";

ESLint Config

module.exports = {
  parser: "@typescript-eslint/parser",
  rules: {
    "@typescript-eslint/no-restricted-imports": ["error", {
      "paths": [
        {
          "name": "foo",
          "allowTypeImports": true
        }
      ]
    }]
  },
};

tsconfig

{
  "compilerOptions": {
    // ...
  }
}

Expected Result

The purpose of type-only imports is to ensure that an import has no runtime behavior, so I would expect that the allowTypeImports option disallows side effect imports such as import 'foo'.

Actual Result

Side effect imports are allowed.

Additional Info

This issue was apparently introduced in typescript-eslint/eslint-plugin 6.3.0, as a result of #7379.
@joshkel joshkel added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Aug 29, 2023
@joshkel joshkel mentioned this issue Aug 29, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look
Projects
None yet
Milestone
No milestone
1 participant
@joshkel
0